Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Apr 3, 2025

This is performing an aggregated group-by query, instead of doing 2N+1 queries resolving all the commit_statuses for the repository.commits as part of the Commits GraphQL query.


Fixes codecov/engineering-team#3401

@Swatinem Swatinem self-assigned this Apr 3, 2025
@Swatinem Swatinem requested a review from a team as a code owner April 3, 2025 13:13
@seer-by-sentry
Copy link
Contributor

seer-by-sentry bot commented Apr 3, 2025

✅ Sentry found no issues in your recent changes ✅

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
graphql_api/types/repository/repository.py 75.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (ab4cb5b) to head (e9a2ff9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
graphql_api/types/repository/repository.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         487      487              
  Lines       16892    16908      +16     
==========================================
+ Hits        16272    16286      +14     
- Misses        620      622       +2     
Flag Coverage Δ
unit 96.32% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is performing an aggregated group-by query, instead of doing 2N+1 queries resolving all the `commit_status`es for the `repository.commits` as part of the `Commits` GraphQL query.
@Swatinem Swatinem force-pushed the swatinem/commitstatus-nplus1 branch from f071b9a to e9a2ff9 Compare April 4, 2025 08:10
@Swatinem Swatinem enabled auto-merge April 4, 2025 08:11
@Swatinem Swatinem added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit 3b261ef Apr 4, 2025
21 of 26 checks passed
@Swatinem Swatinem deleted the swatinem/commitstatus-nplus1 branch April 4, 2025 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API] - Improve CommitStatus resolve time

3 participants