This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Update shared and sentry_sdk
#1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls in an updated version of shared that has more caching, in particular around GitHub calls. Also updates the `sentry_sdk`, and configures it to automatically flag redis calls related to caching.
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1272 +/- ##
==========================================
+ Coverage 96.32% 96.36% +0.03%
==========================================
Files 487 487
Lines 16907 16897 -10
==========================================
- Hits 16285 16282 -3
+ Misses 622 615 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
nicholas-codecov
approved these changes
Apr 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in an updated version of shared that has more caching, in particular around GitHub calls.
Also updates the
sentry_sdk, and configures it to automatically flag redis calls related to caching.Updating the Sentry SDK for some reasons I don’t understand required me to mess with the django signals and shelter integration. On the positive side, we had shelter enabled for tests, which resulted in a shitton of errors being logged to the console, as it was constantly firing requests into nowhere in the background.
This change should thus reduce log spam when running tests, as well as speeding those up a bit.
I can also extract that change as its own PR if necessary.