Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Apr 8, 2025

Previously, the resolver would run a count just to know how many uploads there are, in order to return them all. Lets avoid that, and just use a really huge limit instead.

Previously, the resolver would run a `count` just to know how many uploads there are, in order to return them all. Lets avoid that, and just use a really huge limit instead.
@Swatinem Swatinem self-assigned this Apr 8, 2025
@Swatinem Swatinem requested a review from a team as a code owner April 8, 2025 12:44
@Swatinem Swatinem enabled auto-merge April 8, 2025 12:44
@seer-by-sentry
Copy link
Contributor

seer-by-sentry bot commented Apr 8, 2025

✅ Sentry found no issues in your recent changes ✅

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (382f278) to head (ade3c21).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1277   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         487      487           
  Lines       16907    16907           
=======================================
  Hits        16285    16285           
  Misses        622      622           
Flag Coverage Δ
unit 96.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@Swatinem Swatinem added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 5a55a2a Apr 8, 2025
23 of 24 checks passed
@Swatinem Swatinem deleted the swatinem/no-count-uploads branch April 8, 2025 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants