-
Notifications
You must be signed in to change notification settings - Fork 29
chore: More logging to stripe update default method #1288
Conversation
🚨 Sentry detected 4 potential issues in your recent changes 🚨
Lower risk findings
Did you find this useful? React with a 👍 or 👎 |
joseph-sentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be good to move the dynamic data in the log message to the extra argument and store the relevant info in the same dict that you pass to each log so they all consistently contain the same data
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
- Coverage 96.35% 96.33% -0.03%
==========================================
Files 488 488
Lines 16919 16929 +10
==========================================
+ Hits 16302 16308 +6
- Misses 617 621 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
What is the feature? Why is this being done?
Need to debug: https://codecov.sentry.io/issues/5909837528/?environment=production&project=5215654&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&stream_index=3
we're not getting enough logs in prod
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.