True Tokenless for BA and TA #882

nora-shap · 2024-10-10T23:23:14Z

Purpose/Motivation

TT requires certain identifiers, BA and TA don't have the identifiers in their path, so I make custom methods to get the identifiers so that BA and TA can use TT.

Links to relevant tickets

codecov/engineering-team#2877

codecov-notifications · 2024-10-10T23:35:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codecov · 2024-10-10T23:35:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (b62fc87) to head (56f613b).
Report is 16 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   96.25%   96.26%           
=======================================
  Files         827      827           
  Lines       19090    19113   +23     
=======================================
+ Hits        18376    18399   +23     
  Misses        714      714

Flag	Coverage Δ
unit	`92.53% <100.00%> (+<0.01%)`	⬆️
unit-latest-uploader	`92.53% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joseph-sentry

left a couple of comments on the test results stuff that may also apply to BA

codecov_auth/authentication/repo_auth.py

upload/views/helpers.py

codecov-public-qa · 2024-10-12T01:19:19Z

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2749 tests with 1 failed, 2742 passed and 6 skipped.

View the full list of failed tests

pytest

Class name: api.internal.tests.test_charts.TestChartQueryRunnerQuery
Test name: test_query_aggregates_multiple_repository_totals

self = <tests.test_charts.TestChartQueryRunnerQuery testMethod=test_query_aggregates_multiple_repository_totals>

    @override_settings(GITHUB_CLIENT_ID="3d44be0e772666136a13")
    def test_query_aggregates_multiple_repository_totals(self):
        query_runner = ChartQueryRunner(
            user=self.user,
            request_params={
                "owner_username": self.org.username,
                "service": self.org.service,
                "end_date": str(timezone.now()),
                "grouping_unit": "day",
            },
        )
    
        results = query_runner.run_query()
    
        assert len(results) == 1
>       assert results[0]["total_hits"] == 114
E       AssertionError: assert Decimal('14') == 114

.../internal/tests/test_charts.py:564: AssertionError

codecov-qa · 2024-10-12T01:22:16Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2743	1	2742	6

View the top 1 failed tests by shortest run time

api.internal.tests.test_charts.TestChartQueryRunnerQuery test_query_aggregates_multiple_repository_totals

Stack Traces | 0.072s run time

self = &lt;tests.test_charts.TestChartQueryRunnerQuery testMethod=test_query_aggregates_multiple_repository_totals&gt;

    @override_settings(GITHUB_CLIENT_ID="3d44be0e772666136a13")
    def test_query_aggregates_multiple_repository_totals(self):
        query_runner = ChartQueryRunner(
            user=self.user,
            request_params={
                "owner_username": self.org.username,
                "service": self.org.service,
                "end_date": str(timezone.now()),
                "grouping_unit": "day",
            },
        )
    
        results = query_runner.run_query()
    
        assert len(results) == 1
&gt;       assert results[0]["total_hits"] == 114
E       AssertionError: assert Decimal('14') == 114

.../internal/tests/test_charts.py:564: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov_auth/authentication/repo_auth.py

JerrySentry · 2024-10-14T16:45:32Z

upload/views/test_results.py

 class UploadSerializer(serializers.Serializer):
    commit = serializers.CharField(required=True)
    slug = serializers.CharField(required=True)
+    service = serializers.CharField(required=False)  # git_service


How come TA can't use git_service?

Since it's already live in prod I figured it would be a whole thing to switch over to a different var name - what do you think @joseph-sentry ?

upload/views/helpers.py

…2298

github-actions · 2024-11-09T00:08:38Z

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

nora-shap · 2024-11-11T18:45:16Z

upload/views/test_results.py

+            "service": data.get("service"),  # git provider
            "url": storage_path,  # storage_path
            # these are used for dispatching the task below
            "commit": commit.commitid,


@joseph-sentry can you double check the changes I made to the TA fields? Is this still the design we're going with?

just confirmed, TA sends git_service as service https://github.com/codecov/codecov-cli/blob/2935526caf5db25d64b02870f9cc45e33a7daa3d/codecov_cli/commands/create_report_result.py#L36

these changes should be good to go

JerrySentry

looks good on bundle analysis side of things.

joseph-sentry

lgtm

nora-shap requested a review from a team October 10, 2024 23:23

joseph-sentry reviewed Oct 11, 2024

View reviewed changes

codecov_auth/authentication/repo_auth.py Outdated Show resolved Hide resolved

upload/views/helpers.py Outdated Show resolved Hide resolved

JerrySentry reviewed Oct 11, 2024

View reviewed changes

upload/views/helpers.py Outdated Show resolved Hide resolved

JerrySentry reviewed Oct 11, 2024

View reviewed changes

upload/views/helpers.py Outdated Show resolved Hide resolved

nora-shap force-pushed the nora/2298 branch from f2f587d to 609eaf8 Compare October 12, 2024 01:07

JerrySentry reviewed Oct 14, 2024

View reviewed changes

nora-shap added 3 commits October 15, 2024 13:16

True Tokenless for BA and TA

3cb0f9d

redo the whole thing, condense into one class that both views share

f9d8307

remove this chunk

e5a7000

nora-shap force-pushed the nora/2298 branch from 609eaf8 to e5a7000 Compare October 15, 2024 20:16

nora-shap added 5 commits October 16, 2024 14:05

True Tokenless for BA and TA

dfbfb8e

redo the whole thing, condense into one class that both views share

db650f1

remove this chunk

c91f69e

Merge branch 'nora/2298' of github.com:codecov/codecov-api into nora/…

2264ee4

…2298

merge conflicts

38d9c56

get service the same way as shelter

56f613b

nora-shap commented Nov 11, 2024

View reviewed changes

nora-shap requested review from JerrySentry and joseph-sentry November 12, 2024 19:41

nora-shap mentioned this pull request Nov 12, 2024

feat: Enable true tokenless for bundler plugins codecov/codecov-javascript-bundler-plugins#189

Merged

JerrySentry approved these changes Nov 13, 2024

View reviewed changes

joseph-sentry approved these changes Nov 13, 2024

View reviewed changes

nora-shap added this pull request to the merge queue Nov 13, 2024

Merged via the queue into main with commit 038af97 Nov 13, 2024
18 of 19 checks passed

nora-shap deleted the nora/2298 branch November 13, 2024 20:13

True Tokenless for BA and TA #882

True Tokenless for BA and TA #882

Uh oh!

Conversation

nora-shap commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose/Motivation

Links to relevant tickets

Uh oh!

codecov-notifications bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joseph-sentry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-public-qa bot commented Oct 12, 2024

❌ Failed Test Results:

pytest

Uh oh!

codecov-qa bot commented Oct 12, 2024

❌ 1 Tests Failed:

Uh oh!

Uh oh!

JerrySentry Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

nora-shap Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 9, 2024

Uh oh!

nora-shap Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

nora-shap Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

JerrySentry left a comment

Choose a reason for hiding this comment

Uh oh!

joseph-sentry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nora-shap commented Oct 10, 2024 •

edited

Loading

codecov-notifications bot commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading