From d28038e8ea77d14dcc5bfcebea27d1ec93d92501 Mon Sep 17 00:00:00 2001 From: joseph-sentry Date: Wed, 16 Oct 2024 09:33:44 -0400 Subject: [PATCH] fix: add max to slow test threshold and add tests --- utils/test_results.py | 2 +- utils/tests/unit/test_slow_test_threshold.py | 23 ++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 utils/tests/unit/test_slow_test_threshold.py diff --git a/utils/test_results.py b/utils/test_results.py index fef283ef7c..fa2291c038 100644 --- a/utils/test_results.py +++ b/utils/test_results.py @@ -33,7 +33,7 @@ def slow_test_threshold(total_tests: int) -> int: percentile = (100 - SLOW_TEST_PERCENTILE) / 100 slow_tests_to_return = floor(percentile * total_tests) - return max(slow_tests_to_return, 1) + return min(max(slow_tests_to_return, 1), 100) class ArrayLength(Func): diff --git a/utils/tests/unit/test_slow_test_threshold.py b/utils/tests/unit/test_slow_test_threshold.py new file mode 100644 index 0000000000..93ac4445fe --- /dev/null +++ b/utils/tests/unit/test_slow_test_threshold.py @@ -0,0 +1,23 @@ +import pytest + +from utils.test_results import slow_test_threshold + + +@pytest.mark.parametrize( + "total_tests, expected_threshold", + [ + (0, 1), + (1, 1), + (10, 1), + (100, 5), + (1000, 50), + (10000, 100), + (1000000, 100), + (20, 1), + (50, 2), + (200, 10), + (2000, 100), + ], +) +def test_slow_test_threshold(total_tests, expected_threshold): + assert slow_test_threshold(total_tests) == expected_threshold