-
Notifications
You must be signed in to change notification settings - Fork 29
fix: search_base_query to handle desc ordering #907
Conversation
| assert res == rows[-1:] | ||
|
|
||
|
|
||
| def test_search_base_query_with_missing_cursor_low_name_high_failure_rate_desc(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ngl I have no idea what this test name is telling me LOL
utils/test_results.py
Outdated
| cursor_value_str = cursor.ordered_value | ||
| return (row_value_str > cursor_value_str) - (row_value_str < cursor_value_str) | ||
| if descending: | ||
| return (row_value_str < cursor_value_str) - ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we can find a name for row_value_str < cursor_value_str and row_value_str > cursor_value_str such that we can have something like
varOne - varTwo if descending else varTwo - varOne
It took me a sec to realize that the terms in each equation were the same, just flipped
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
- Coverage 96.25% 96.24% -0.01%
==========================================
Files 823 823
Lines 19049 19054 +5
==========================================
+ Hits 18335 18339 +4
- Misses 714 715 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 2713 tests with View the full list of failed testspytest
|
No description provided.