Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

bundle analysis: prometheus, remove try/catch #908

Merged
merged 2 commits into from
Oct 21, 2024
Merged

bundle analysis: prometheus, remove try/catch #908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c3de18
bundle analysis: prometheus, remove try/catch
JerrySentry Oct 21, 2024
1991bb8
update metrics description
JerrySentry Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 17 additions & 31 deletions upload/views/bundle_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER = Counter(
"bundle_analysis_upload_views_runs",
"Number of times a raw report processor was run and with what result",
"Number of times a BA upload was run and with what result",
[
"agent",
"version",
Expand Down Expand Up @@ -80,21 +80,14 @@ def get_exception_handler(self) -> Callable:
return repo_auth_custom_exception_handler

def post(self, request: HttpRequest) -> Response:
try:
labels = generate_upload_sentry_metrics_tags(
action="bundle_analysis",
endpoint="bundle_analysis",
request=self.request,
is_shelter_request=self.is_shelter_request(),
position="start",
)
BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER.labels(**labels).inc()
except Exception:
log.warn(
"Failed to BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER",
exc_info=True,
extra=labels,
)
labels = generate_upload_sentry_metrics_tags(
action="bundle_analysis",
endpoint="bundle_analysis",
request=self.request,
is_shelter_request=self.is_shelter_request(),
position="start",
)
BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER.labels(**labels).inc()

serializer = UploadSerializer(data=request.data)
if not serializer.is_valid():
Expand Down Expand Up @@ -174,21 +167,14 @@ def post(self, request: HttpRequest) -> Response:
task_arguments=task_arguments,
),
)
try:
labels = generate_upload_sentry_metrics_tags(
action="bundle_analysis",
endpoint="bundle_analysis",
request=self.request,
is_shelter_request=self.is_shelter_request(),
position="end",
)
BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER.labels(**labels).inc()
except Exception:
log.warn(
"Failed to BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER",
exc_info=True,
extra=labels,
)
labels = generate_upload_sentry_metrics_tags(
action="bundle_analysis",
endpoint="bundle_analysis",
request=self.request,
is_shelter_request=self.is_shelter_request(),
position="end",
)
BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER.labels(**labels).inc()

dispatch_upload_task(
task_arguments,
Expand Down
Loading