Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Clean up unused minio.periodic_callback_ms field #989

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Clean up unused minio.periodic_callback_ms field #989

merged 1 commit into from
Dec 4, 2024

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Nov 18, 2024

No description provided.

@Swatinem Swatinem requested a review from a team November 18, 2024 12:46
@Swatinem Swatinem self-assigned this Nov 18, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (ace92d6) to head (254296f).
Report is 21 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         828      828           
  Lines       19166    19166           
=======================================
  Hits        18407    18407           
  Misses        759      759
Flag Coverage Δ
unit 92.31% <ø> (ø)
unit-latest-uploader 92.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

adrian-codecov
adrian-codecov approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this used for before?

@Swatinem
Copy link
Contributor Author

Swatinem commented Dec 4, 2024

https://docs.codecov.com/v4.6/docs/archiving-reports#general-instructions mentions this flag.
But otherwise I couldn’t find any reference where this is actually used.

@Swatinem Swatinem added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 3813d1b Dec 4, 2024
19 checks passed
@Swatinem Swatinem deleted the swatinem/cleanup-minio branch December 4, 2024 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@adrian-codecov adrian-codecov adrian-codecov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Swatinem Swatinem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Swatinem @adrian-codecov