Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Upgrade shared to latest #998

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Upgrade shared to latest #998

merged 1 commit into from
Nov 22, 2024

Conversation

@michelletran-sentry
Copy link
Contributor

@michelletran-sentry michelletran-sentry commented Nov 22, 2024

This is to test out the uv changes

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited
Loading

This PR includes changes to shared. Please review them here: codecov/shared@9c31870...f96b72f

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (c040388) to head (e8caa53).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #998   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         828      828           
  Lines       19186    19186           
=======================================
  Hits        18427    18427           
  Misses        759      759
Flag Coverage Δ
unit 92.32% <ø> (ø)
unit-latest-uploader 92.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michelletran-sentry
michelletran-sentry commented Nov 22, 2024
View reviewed changes
requirements.in
https://github.com/photocrowd/django-cursor-pagination/archive/f560902696b0c8509e4d95c10ba0d62700181d84.tar.gz
idna>=3.7
minio
oauth2==1.9.0.post1
Copy link
Contributor Author

@michelletran-sentry michelletran-sentry Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a dependency on this for bitbucket. Specifying it explicitly.

@codecov-qa
Copy link

codecov-qa bot commented Nov 22, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2690 1 2689 6
View the top 1 failed tests by shortest run time 
core/commands/repository/interactors/tests/test_fetch_repository.py::FetchRepositoryInteractorTest::test_fetch_public_repo_unauthenticated
Stack Traces | 0.409s run time 
self = <core.commands.repository.interactors.tests.test_fetch_repository.FetchRepositoryInteractorTest testMethod=test_fetch_public_repo_unauthenticated>

    async def test_fetch_public_repo_unauthenticated(self):
        repo = await self.execute(None, self.org, self.public_repo.name, [])
>       assert repo == self.public_repo
E       assert None == <Repository: Repo<Owner<github/matthewaguilar>/per>>
E        +  where <Repository: Repo<Owner<github/matthewaguilar>/per>> = <core.commands.repository.interactors.tests.test_fetch_repository.FetchRepositoryInteractorTest testMethod=test_fetch_public_repo_unauthenticated>.public_repo

.../interactors/tests/test_fetch_repository.py:37: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@codecov-public-qa
Copy link

codecov-public-qa bot commented Nov 22, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2690 1 2689 6
View the top 1 failed tests by shortest run time 
core/commands/repository/interactors/tests/test_fetch_repository.py::FetchRepositoryInteractorTest::test_fetch_public_repo_unauthenticated
Stack Traces | 0.409s run time 
self = &lt;core.commands.repository.interactors.tests.test_fetch_repository.FetchRepositoryInteractorTest testMethod=test_fetch_public_repo_unauthenticated&gt;

    async def test_fetch_public_repo_unauthenticated(self):
        repo = await self.execute(None, self.org, self.public_repo.name, [])
&gt;       assert repo == self.public_repo
E       assert None == &lt;Repository: Repo&lt;Owner&lt;github/matthewaguilar&gt;/per&gt;&gt;
E        +  where &lt;Repository: Repo&lt;Owner&lt;github/matthewaguilar&gt;/per&gt;&gt; = &lt;core.commands.repository.interactors.tests.test_fetch_repository.FetchRepositoryInteractorTest testMethod=test_fetch_public_repo_unauthenticated&gt;.public_repo

.../interactors/tests/test_fetch_repository.py:37: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@michelletran-sentry michelletran-sentry mentioned this pull request Nov 22, 2024
Merged
@michelletran-sentry michelletran-sentry marked this pull request as ready for review November 22, 2024 17:00
@michelletran-sentry
Upgrade shared to latest
e8caa53 
This is to test out the uv changes
adrian-codecov
adrian-codecov reviewed Nov 22, 2024
View reviewed changes
requirements.in
freezegun
https://github.com/codecov/opentelem-python/archive/refs/tags/v0.0.4a1.tar.gz#egg=codecovopentelem
https://github.com/codecov/shared/archive/9c31870de026a8a3f026f0753b1991e8c832fadb.tar.gz#egg=shared
https://github.com/codecov/shared/archive/f96b72f47583a083e0c78ec7c7ff4da5d3ad6a19.tar.gz#egg=shared
Copy link
Contributor

@adrian-codecov adrian-codecov Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this also need to get rid of the things in services/task.py?

Copy link
Contributor Author

@michelletran-sentry michelletran-sentry Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We should probably still upgrade that at some point, but this only loosens the allowable dependencies to let us use an older version of sentry-sdk.

@michelletran-sentry michelletran-sentry added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit a2a4844 Nov 22, 2024
19 checks passed
@michelletran-sentry michelletran-sentry deleted the upgrade_api_shared branch November 22, 2024 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@adrian-codecov adrian-codecov adrian-codecov approved these changes

@suejung-sentry suejung-sentry suejung-sentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michelletran-sentry @adrian-codecov @suejung-sentry