Merge pull request #166 from codecov/dana/check-head-base-shas

do not run label analysis unless head and base shas are different

Author: dana-yaish

codecov_cli/commands/labelanalysis.py

@@ -69,6 +69,19 @@ def label_analysis(
             )
         ),
     )
+    if head_commit_sha == base_commit_sha:
+        logger.error(
+            "Base and head sha can't be the same",
+            extra=dict(
+                extra_log_attributes=dict(
+                    head_commit_sha=head_commit_sha,
+                    base_commit_sha=base_commit_sha,
+                )
+            ),
+        )
+        raise click.ClickException(
+            click.style("Unable to run label analysis", fg="red")
+        )
     upload_url = enterprise_url or CODECOV_API_URL
     url = f"{upload_url}/labels/labels-analysis"
     token_header = f"Repotoken {token}"

tests/commands/test_invoke_labelanalysis.py

@@ -86,6 +86,25 @@ def test_invoke_label_analysis_missing_base_sha(self, mocker, fake_ci_provider):
         assert result.exit_code != 0
         assert "Error: Missing option '--base-sha'." in result.output
 
+    def test_invoke_label_analysis_base_sha_same_as_head_sha(
+        self, mocker, fake_ci_provider
+    ):
+        mocker.patch("codecov_cli.main.get_ci_adapter", return_value=fake_ci_provider)
+        runner = CliRunner()
+
+        result = runner.invoke(
+            cli,
+            [
+                "label-analysis",
+                "--token=STATIC_TOKEN",
+                "--base-sha=commit-sha",
+                "--head-sha=commit-sha",
+            ],
+            obj={},
+        )
+        assert result.exit_code != 0
+        assert "Base and head sha can't be the same" in result.output
+
     def test_invoke_label_analysis(self, get_labelanalysis_deps, mocker):
         mock_get_runner = get_labelanalysis_deps["mock_get_runner"]
         fake_runner = get_labelanalysis_deps["fake_runner"]