fix: log info if a file shows up as a directory (#430)

* fix: log info if a file shows up as a directory

* fix: black

* fix: lint

Author: thomasrockhu-codecov

codecov_cli/helpers/folder_searcher.py

@@ -58,7 +58,7 @@ def search_files(
     this_is_excluded = functools.partial(
         _is_excluded, filename_exclude_regex, multipart_exclude_regex
     )
-    for (dirpath, dirnames, filenames) in os.walk(folder_to_search):
+    for dirpath, dirnames, filenames in os.walk(folder_to_search):
         dirs_to_remove = set(d for d in dirnames if d in folders_to_ignore)
 
         if multipart_exclude_regex is not None:

codecov_cli/helpers/git_services/github.py

@@ -24,9 +24,11 @@ def get_pull_request(self, slug, pr_number) -> PullDict:
                     "ref": res["head"]["ref"],
                     # Through empiric test data it seems that the "repo" key in "head" is set to None
                     # If the PR is from the same repo (e.g. not from a fork)
-                    "slug": res["head"]["repo"]["full_name"]
-                    if res["head"]["repo"]
-                    else res["base"]["repo"]["full_name"],
+                    "slug": (
+                        res["head"]["repo"]["full_name"]
+                        if res["head"]["repo"]
+                        else res["base"]["repo"]["full_name"]
+                    ),
                 },
                 "base": {
                     "sha": res["base"]["sha"],

codecov_cli/helpers/versioning_systems.py

@@ -135,9 +135,11 @@ def list_relevant_files(
         )
 
         return [
-            filename[1:-1]
-            if filename.startswith('"') and filename.endswith('"')
-            else filename
+            (
+                filename[1:-1]
+                if filename.startswith('"') and filename.endswith('"')
+                else filename
+            )
             for filename in res.stdout.decode("unicode_escape").strip().split("\n")
         ]
 

codecov_cli/services/staticanalysis/analyzers/general.py

@@ -85,13 +85,13 @@ def _get_parent_chain(self, node):
 
     def get_import_lines(self, root_node, imports_query):
         import_lines = set()
-        for (a, _) in imports_query.captures(root_node):
+        for a, _ in imports_query.captures(root_node):
             import_lines.add((a.start_point[0] + 1, a.end_point[0] - a.start_point[0]))
         return import_lines
 
     def get_definition_lines(self, root_node, definitions_query):
         definition_lines = set()
-        for (a, _) in definitions_query.captures(root_node):
+        for a, _ in definitions_query.captures(root_node):
             definition_lines.add(
                 (a.start_point[0] + 1, a.end_point[0] - a.start_point[0])
             )

codecov_cli/services/upload/upload_collector.py

@@ -139,6 +139,8 @@ def _get_file_fixes(
                     reason=err.reason,
                 ),
             )
+        except IsADirectoryError as err:
+            logger.info(f"Skipping {filename}, found a directory not a file")
 
         return UploadCollectionResultFileFixer(
             path, fixed_lines_without_reason, fixed_lines_with_reason, eof