v9.1.0 breaks `codecov-action@v4` due to changes in the uploader

[PacificGilly]

Issue

Since v9.1.0 was released, the codecov-action@v4 now breaks when trying to upload the coverage reports.

This seems to have occurred due to #551 introducing two new position arguments:

• parent_sha
• upload_coverage

to sender.send_upload_data

Expected

That I can upload my coverage reports without issue.

Setup (obfuscated where needed)

    - name: Collect coverage
      uses: codecov/codecov-action@v4
      if: inputs.codecov-token != ''
      with:
        codecov_yml_path: /home/runner/_work/***/codecov.yml
        fail_ci_if_error: true
        slug: ***
        token: ***
        url: https://codecov.***.com/
        use_legacy_upload_endpoint: true
        verbose: true

Error message:

debug - 2024-12-05 12:07:32,144 -- Selected uploader to use: <class 'codecov_cli.services.upload.legacy_upload_sender.LegacyUploadSender'>
Traceback (most recent call last):
  File "codecov_cli/main.py", line 89, in <module>
  File "codecov_cli/main.py", line 85, in run
  File "click/core.py", line 1157, in __call__
  File "click/core.py", line 1078, in main
  File "click/core.py", line 1688, in invoke
  File "click/core.py", line 1[434](https://git.***.com/lyst/***/actions/runs/330950/job/958755#step:4:448), in invoke
  File "click/core.py", line 783, in invoke
  File "click/decorators.py", line 33, in new_func
  File "codecov_cli/commands/upload.py", line 261, in do_upload
  File "codecov_cli/services/upload/__init__.py", line 135, in do_upload_logic
TypeError: LegacyUploadSender.send_upload_data() takes from 5 to 19 positional arguments but 21 were given
[PYI-873:ERROR] Failed to execute script 'main' due to unhandled exception!

Solution

Possible solutions

• As this is all "in-house" tooling, work with codecov-action team to fix this issue in v4 of GHA
• Get codecov-action to pin the version of the CLI being used until it can be verified it works

Workarounds

• Pin the version uses in codecov-action, (e.g. "v9.0.4") but thought to raise issue here as this regression as introduced into this repo.

[thomasrockhu-codecov]

Fix pending release of CLI

[thomasrockhu-codecov]

@PacificGilly this should be fixed in 9.1.1

[PacificGilly]

Amazing, thanks so much for the speedy fix on this ♥️