Skip to content

chore: Resolve vite vulns #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 14, 2024
Merged

chore: Resolve vite vulns #186

merged 9 commits into from
Nov 14, 2024

Conversation

@suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Nov 8, 2024 •
edited
Loading

Upgrade vite versions to resolve vulnerability. Resolved versions:

  • 5.4.11
  • 5.3.6
  • 5.2.14
  • 5.1.8
  • 4.5.4

Closes https://github.com/codecov/internal-issues/issues/934
Closes https://github.com/codecov/internal-issues/issues/932

@codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (7767739) to head (f81dc50).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 97.07% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 97.07% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

📢 Thoughts on this report? Let us know!

@suejung-sentry suejung-sentry changed the title chore: Resolve vite, rollup vulns chore: Resolve vite vulns Nov 13, 2024
@suejung-sentry suejung-sentry marked this pull request as ready for review November 14, 2024 05:26
@codecov-staging
Copy link

codecov-staging bot commented Nov 14, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 98 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/example-vite-app-esm 150.71kB 98 bytes (0.07%) ⬆️

@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 39.27kB (-0.68%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/bundler-plugin-core-esm 12.29kB 40.99kB (-76.94%) ⬇️
@codecov/rollup-plugin-esm 2.32kB 1.02kB (78.42%) ⬆️
@codecov/nuxt-plugin-esm 1.23kB 397 bytes (47.83%) ⬆️
@codecov/sveltekit-plugin-esm 891 bytes 198 bytes (-18.18%) ⬇️
@codecov/example-solidstart-app-esm 33.76kB 24 bytes (0.07%) ⬆️
@codecov/example-vite-app-esm 150.71kB 98 bytes (0.07%) ⬆️
@codecov/example-solidstart-app-client-esm 47.91kB 106 bytes (0.22%) ⬆️
@codecov/example-nuxt-app-client-esm 242.71kB 118 bytes (0.05%) ⬆️
@codecov/solidstart-plugin-esm 1.09kB 142 bytes (14.96%) ⬆️
@codecov/example-remix-app-client-esm 251.34kB 783 bytes (-0.31%) ⬇️
@codecov/example-remix-app-server-esm 12.56kB 12 bytes (0.1%) ⬆️
@codecov/example-sveltekit-app-client-esm 715.09kB 112 bytes (0.02%) ⬆️
@codecov/example-sveltekit-app-server-esm 974.29kB 557 bytes (-0.06%) ⬇️
@codecov/example-solidstart-app-server-esm 79.0kB 24 bytes (0.03%) ⬆️
@codecov/nextjs-webpack-plugin-esm 1.87kB 753 bytes (67.59%) ⬆️
@codecov/example-tokenless-app-esm 150.67kB 98 bytes (0.07%) ⬆️
@codecov/bundle-analyzer-esm 3.45kB 347 bytes (11.17%) ⬆️

@suejung-sentry suejung-sentry merged commit b17f870 into main Nov 14, 2024
62 checks passed
@suejung-sentry suejung-sentry deleted the sshin/chore/vuln branch November 14, 2024 21:33
@suejung-sentry suejung-sentry mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nicholas-codecov nicholas-codecov nicholas-codecov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suejung-sentry @nicholas-codecov