Skip to content

fix: add github permissions #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

fix: add github permissions #263

merged 1 commit into from
May 30, 2025

Conversation

@thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented May 30, 2025 •
edited
Loading

Description

Adding in explicit permissions for the GITHUB_TOKEN to address security issues (see https://github.com/codecov/codecov-javascript-bundler-plugins/security/code-scanning/79 as an example)

Code Example

Notable Changes

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (9c514a9) to head (74a2784).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 98.05% <ø> (ø)
Rollup plugin 8.42% <ø> (ø)
Vite plugin 8.42% <ø> (ø)
Webpack plugin 56.84% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented May 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 98.05% <ø> (ø)
Rollup plugin 8.42% <ø> (ø)
Vite plugin 8.42% <ø> (ø)
Webpack plugin 56.84% <ø> (ø)

📢 Thoughts on this report? Let us know!

@codecov-staging
Copy link

codecov-staging bot commented May 30, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 310.19kB (4.09%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/bundler-plugin-core-esm 312.6kB 297.93kB (2030.71%) ⬆️
@codecov/bundle-analyzer-esm 6.9kB 3.79kB (122.05%) ⬆️
@codecov/sveltekit-plugin-esm 3.03kB 2.13kB (239.62%) ⬆️
@codecov/solidstart-plugin-esm 949 bytes -2.08kB (-68.72%) ⬇️
@codecov/example-next-15-app-client-array-push 1.05MB 10.83kB (1.05%) ⬆️
@codecov/astro-plugin-esm 862 bytes -2.41kB (-73.62%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: @codecov/vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 1.24kB 1.24kB 100.0% 🚀
index.d.mts (Deleted) -1.24kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-next-15-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/media/8e9860b6e62d6359-*.woff2 (New) 85.27kB 85.27kB 100.0% 🚀
static/media/e4af272ccee01ff0-*.p.woff2 (New) 48.43kB 48.43kB 100.0% 🚀
server/middleware-*.js -873 bytes 36 bytes -96.04%
server/middleware-*.js 873 bytes 909 bytes 2425.0% ⚠️
static/w5bQH0f7DP9p8_xYYcm8Q/_buildManifest.js (New) 540 bytes 540 bytes 100.0% 🚀
static/w5bQH0f7DP9p8_xYYcm8Q/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/media/6d93bde91c0c2823-*.woff2 (Deleted) -74.32kB 0 bytes -100.0% 🗑️
static/media/a34f9d1faa5f3315-*.p.woff2 (Deleted) -48.56kB 0 bytes -100.0% 🗑️
static/u3i2v4D7yt5o2TrqxJgX2/_buildManifest.js (Deleted) -540 bytes 0 bytes -100.0% 🗑️
static/u3i2v4D7yt5o2TrqxJgX2/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
manifest_iX4zoziJ.mjs (New) 3.34kB 3.34kB 100.0% 🚀
manifest_BGspVYXq.mjs (Deleted) -3.34kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 3.45kB 3.45kB 100.0% 🚀
index.d.cts (Deleted) -3.45kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundler-plugin-core-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 312.6kB 312.6kB 100.0% 🚀
index.d.cts (Deleted) -14.67kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/solidstart-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 949 bytes 949 bytes 100.0% 🚀
index.mjs (Deleted) -3.03kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/sveltekit-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.03kB 3.03kB 100.0% 🚀
index.d.ts (Deleted) -891 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-next-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/zwFlrMVVs5qDHsqETuKzW/_buildManifest.js (New) 224 bytes 224 bytes 100.0% 🚀
static/zwFlrMVVs5qDHsqETuKzW/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/CdJhhV4Nm9mZ4a1j0IDn7/_buildManifest.js (Deleted) -224 bytes 0 bytes -100.0% 🗑️
static/CdJhhV4Nm9mZ4a1j0IDn7/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/astro-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 862 bytes 862 bytes 100.0% 🚀
index.mjs (Deleted) -3.27kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-5-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
manifest_BuezdQqB.mjs (New) 3.37kB 3.37kB 100.0% 🚀
manifest_ywSiwne9.mjs (Deleted) -3.37kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundle-analyzer-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.92kB 3.92kB 100.0% 🚀
cli.mjs (New) 2.98kB 2.98kB 100.0% 🚀
index.d.ts (Deleted) -2.77kB 0 bytes -100.0% 🗑️
cli.d.ts (Deleted) -342 bytes 0 bytes -100.0% 🗑️

@codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 10.83kB (0.14%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/example-next-15-app-client-array-push 1.05MB 10.83kB (1.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @codecov/example-next-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/_fCtroYEwbxJtz73sWPap/_buildManifest.js (New) 224 bytes 224 bytes 100.0% 🚀
static/_fCtroYEwbxJtz73sWPap/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/bh7tw4vdvemM1nU2Yu7ey/_buildManifest.js (Deleted) -224 bytes 0 bytes -100.0% 🗑️
static/bh7tw4vdvemM1nU2Yu7ey/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-next-15-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/media/8e9860b6e62d6359-*.woff2 (New) 85.27kB 85.27kB 100.0% 🚀
static/media/e4af272ccee01ff0-*.p.woff2 (New) 48.43kB 48.43kB 100.0% 🚀
server/middleware-*.js -873 bytes 36 bytes -96.04%
server/middleware-*.js 873 bytes 909 bytes 2425.0% ⚠️
static/HoZ6spR3Lj6Gyg8Wryit0/_buildManifest.js (New) 540 bytes 540 bytes 100.0% 🚀
static/HoZ6spR3Lj6Gyg8Wryit0/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/media/6d93bde91c0c2823-*.woff2 (Deleted) -74.32kB 0 bytes -100.0% 🗑️
static/media/a34f9d1faa5f3315-*.p.woff2 (Deleted) -48.56kB 0 bytes -100.0% 🗑️
static/gX2Ir9rKnW7qImXwS9wpU/_buildManifest.js (Deleted) -540 bytes 0 bytes -100.0% 🗑️
static/gX2Ir9rKnW7qImXwS9wpU/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 3.45kB 3.45kB 100.0% 🚀
index.d.cts (Deleted) -3.45kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundle-analyzer-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 2.77kB 2.77kB 100.0% 🚀
cli.d.mts (New) 342 bytes 342 bytes 100.0% 🚀
index.d.ts (Deleted) -2.77kB 0 bytes -100.0% 🗑️
cli.d.ts (Deleted) -342 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
manifest_BAtZjTCP.mjs (New) 3.34kB 3.34kB 100.0% 🚀
manifest_7Ip_uUuP.mjs (Deleted) -3.34kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 1.24kB 1.24kB 100.0% 🚀
index.d.ts (Deleted) -1.24kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/sveltekit-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 891 bytes 891 bytes 100.0% 🚀
index.d.ts (Deleted) -891 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/solidstart-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 949 bytes 949 bytes 100.0% 🚀
index.d.ts (Deleted) -949 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/nextjs-webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 1.11kB 1.11kB 100.0% 🚀
index.d.cts (Deleted) -1.11kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/astro-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.cts (New) 862 bytes 862 bytes 100.0% 🚀
index.d.mts (Deleted) -862 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-5-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
manifest_B4HD_OWn.mjs (New) 3.37kB 3.37kB 100.0% 🚀
manifest_C6_HwCp6.mjs (Deleted) -3.37kB 0 bytes -100.0% 🗑️

suejung-sentry
suejung-sentry approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - can we add a quick description to the PR on why we are adding this permission to all these different workflows?
Guessing it's related to a feature we want to dogfood here?

@thomasrockhu-codecov thomasrockhu-codecov merged commit 866e31a into main May 30, 2025
70 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/github-permissions branch May 30, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suejung-sentry suejung-sentry suejung-sentry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomasrockhu-codecov @suejung-sentry