remove timer because slow CI servers need more than half a second before data is flowing - switch to use --pipe or -l as signal to codecov to recieve data via stdin

Author: dotnetCarpenter

bin/codecov

@@ -20,28 +20,21 @@ var args = argv.option([
   {name: 'slug', short: 'r', type: 'string', description: "Specify repository slug for Enterprise ex. owner/repo"},
   {name: 'url', short: 'u', type: 'string', description: "Your Codecov endpoint"},
   {name: 'flags', short: 'F', type: 'string', description: "Codecov Flags"},
-  {name: 'dump', type: 'boolean', description: "Dump collected data and do not send to Codecov"}
+  {name: 'dump', type: 'boolean', description: "Dump collected data and do not send to Codecov"},
+  {name: 'pipe', short: 'l', type: 'boolean', description: "Listen to stdin for coverage data"}
 ]).run();
 
-// listen for piped input for 500ms
-var listeningTime = 500;
-var readingPiped = false;
-process.stdin.setEncoding('utf8');
-process.stdin.on('data', function(report) {
-  if (report !== null) {
-    readingPiped = true;
-    clearTimeout(timer);
-    if (!args.options.pipe) args.options.pipe = [];
+if (args.options.pipe) {
+  process.stdin.setEncoding('utf8');
+  args.options.pipe = [];
+
+  process.stdin.on('data', function(report) {
     args.options.pipe.push(report);
-  }
-});
-process.stdin.on('end', function() {
-  if (readingPiped) codecov.upload(args);
-});
+  });
 
-var timer = setTimeout(function() {
-  if (!readingPiped) {
+  process.stdin.on('end', function() {
     codecov.upload(args);
-    process.exit();
-  }
-}, listeningTime);
+  });
+} else {
+  codecov.upload(args);
+}

test/index.js

@@ -38,8 +38,8 @@ describe("Codecov", function(){
   });
 
   it("can specify report in cli", function(){
-    var res = codecov.upload({options: {dump: true, file: 'test' + pathSeparator + 'coverage.json'}});
-    expect(res.files[0].split(pathSeparator).pop()).to.eql('coverage.json');
+    var res = codecov.upload({options: {dump: true, file: 'test' + pathSeparator + 'example.coverage.txt'}});
+    expect(res.files[0].split(pathSeparator).pop()).to.eql('example.coverage.txt');
     expect(res.body).to.contain('this file is intentionally left blank');
   });
 
@@ -134,7 +134,7 @@ describe("Codecov", function(){
 
   it("can read piped reports", function(done){
     var exec = require('child_process').exec;
-    var childProcess = exec('cat test/coverage.json | bin/codecov --dump --disable=gcov', function(err, stdout, stderr){
+    var childProcess = exec('cat test/example.coverage.txt | bin/codecov -l --dump --disable=gcov', function(err, stdout, stderr){
       expect(stdout.toString()).to.contain('path=piped');
       expect(stdout.toString()).to.contain('this file is intentionally left blank');
       childProcess.kill();