-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
Description
The "local upload" feature currently works by passing a report_code to all the various upload-related CLI commands and API calls.
The upload processing is then run as usual, but results are stored slightly differently:
- The
report_jsonis stored once per commit. - But a different
chunksfile is stored depending on thereport_code.
We can thus end up in a situation where the report_json/chunks get out of sync, and a "local upload" corrupts an existing commit report by overwriting its report_json with one that does not correspond to the main chunks file anymore.
For this reason, I believe that the "local upload" feature is fundamentally broken. We should thus work towards deprecating and removing it.
Removing the "local upload" and report_code feature also opens up the possibility to tackle some further internal refactorings:
- Deprecate "local upload" related commands codecov-cli#679
- Deprecate the "local upload"
ReportResultsendpoints codecov-api#1291 - Remove "local upload" related
save_report_resultstask worker#1214 - Clean up some
report_codeusage umbrella#63 - Fully remove and disallow non-default
report_codeumbrella#81 - Cleanup
staticanalysisandlocal-uploadrelated entities umbrella#80