Your Feedback about Impact Analysis

[eliatcodecov]

[mikebronner]

I installed the Laravel package, and am seeing the following error:

Error Call to undefined method Symfony\Component\HttpFoundation\BinaryFileResponse::status() 
    vendor/codecov/laravel-codecov-opentelemetry/src/Middleware/Trace.php:84 Codecov\LaravelCodecovOpenTelemetry\Middleware\Trace::handle
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:180 Illuminate\Pipeline\Pipeline::Illuminate\Pipeline\{closure}
    vendor/mikefrancis/laravel-secureheaders/src/ApplySecureHeaders.php:48 MikeFrancis\LaravelSecureHeaders\ApplySecureHeaders::handle
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:180 Illuminate\Pipeline\Pipeline::Illuminate\Pipeline\{closure}
    vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php:21 Illuminate\Foundation\Http\Middleware\TransformsRequest::handle
    vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php:31 Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::handle
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:180 Illuminate\Pipeline\Pipeline::Illuminate\Pipeline\{closure}
    vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php:21 Illuminate\Foundation\Http\Middleware\TransformsRequest::handle
    vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php:40 Illuminate\Foundation\Http\Middleware\TrimStrings::handle
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:180 Illuminate\Pipeline\Pipeline::Illuminate\Pipeline\{closure}
    vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php:27 Illuminate\Foundation\Http\Middleware\ValidatePostSize::handle
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:180 Illuminate\Pipeline\Pipeline::Illuminate\Pipeline\{closure}
    vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php:86 Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance::handle
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:180 Illuminate\Pipeline\Pipeline::Illuminate\Pipeline\{closure}
    vendor/laravel/framework/src/Illuminate/Http/Middleware/HandleCors.php:49 Illuminate\Http\Middleware\HandleCors::handle
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:180 Illuminate\Pipeline\Pipeline::Illuminate\Pipeline\{closure}
    vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php:39 Illuminate\Http\Middleware\TrustProxies::handle
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:180 Illuminate\Pipeline\Pipeline::Illuminate\Pipeline\{closure}
    vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:116 Illuminate\Pipeline\Pipeline::then
    vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:142 Illuminate\Foundation\Http\Kernel::sendRequestThroughRouter
    vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:111 Illuminate\Foundation\Http\Kernel::handle
    public/index.php:52 [main]

This does NOT happen on every request, so far about 8 times. It also appears to happen randomly, there doesn't seem to be a pattern as to which pages it happens on.

[eliatcodecov]

👋 Hello @mikebronner and thanks for your feedback. Can you let me know what version of the package you are using so I can try to run this down?

[mikebronner]

👋 Hello @mikebronner and thanks for your feedback. Can you let me know what version of the package you are using so I can try to run this down?

This from composer.lock:

            "name": "codecov/laravel-codecov-opentelemetry",
            "version": "v0.1.5",

I have turned this feature off until this can be solved, as it was impacting production.

[eliatcodecov]

It looks like the issue is here:

$this->setSpanStatus($span, $response->status());

as denoted by the stack trace:

Error Call to undefined method Symfony\Component\HttpFoundation\BinaryFileResponse::status() 

Essentially the returned status from the response object is of the type BinaryFileResponse, which doesn't have a status function. It's trivial to wrap this part of the package in some conditional to ensure the status() function exists before using it, but I'm more interested in why a BinaryFileResponse is coming back in the first place.

You mention this is occurring intermittently. Are there specific requests in your system where a BinaryFileResponse is expected behavior? An example here would be if you have an endpoint that, perhaps, serves static files. Do you routinely see failures on endpoints that may be serving static assets?

In the meantime I'll get a PR together to resolve the issue indicated by the stack trace.

[mikebronner]

Hi Eli, thanks for looking into this. As you can see from the stack trace, this is not happening in our app's code. These appear to happen in Livewire AJAX requests using the GET method, so it would appear unrelated to the request itself, but might have something to do with how Livewire handles it internally.

[eliatcodecov]

🤔 I'll dig into the livewire internals a bit, but I don't think it changes the straightforward fix that much. You can track the progress of that fix here:

codecov/opentelem-laravel#33

Looks like composer is upset in the CI, and I still want to review this change and get some tests on it if I can, but I'll try to get this merged as soon as I can for you and do a 0.1.6 release of the package.

[eliatcodecov]

@mikebronner This should be fixed in v0.1.6. Release notes here: https://github.com/codecov/opentelem-laravel/releases/tag/v0.1.6

[mikebronner]

thanks, I'll update and test again :)