Skip to content

Commit 6a6fd2c

Browse files
authored
dev: Clean up some unneccesary mocks to speed up gazebo tests (#3604)
1 parent fdd77d4 commit 6a6fd2c

File tree

5 files changed

+9
-46
lines changed

5 files changed

+9
-46
lines changed

src/pages/DefaultOrgSelector/DefaultOrgSelector.test.jsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ const wrapper =
159159
)
160160

161161
beforeAll(() => {
162+
console.error = () => {}
162163
server.listen({
163164
onUnhandledRequest: 'warn',
164165
})
@@ -169,6 +170,7 @@ afterEach(() => {
169170
})
170171
afterAll(() => {
171172
server.close()
173+
vi.resetAllMocks()
172174
})
173175

174176
describe('DefaultOrgSelector', () => {
@@ -1296,7 +1298,7 @@ describe('DefaultOrgSelector', () => {
12961298

12971299
describe('on fetch next page', () => {
12981300
it('renders next page', async () => {
1299-
const { user, fetchNextPage } = setup({
1301+
const { fetchNextPage } = setup({
13001302
useUserData: mockUserData,
13011303
myOrganizationsData: {
13021304
me: {
@@ -1318,12 +1320,6 @@ describe('DefaultOrgSelector', () => {
13181320
render(<DefaultOrgSelector />, { wrapper: wrapper() })
13191321
mocks.useIntersection.mockReturnValue({ isIntersecting: true })
13201322

1321-
const selectOrg = await screen.findByRole('button', {
1322-
name: 'Select an organization',
1323-
})
1324-
1325-
await user.click(selectOrg)
1326-
13271323
await waitFor(() => expect(fetchNextPage).toHaveBeenCalled())
13281324
await waitFor(() => expect(fetchNextPage).toHaveBeenCalledWith('MTI='))
13291325
})

src/pages/RepoPage/CommitsTab/CommitsTab.test.jsx

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -333,16 +333,6 @@ describe('CommitsTab', () => {
333333
})
334334

335335
describe('when select onLoadMore is triggered', () => {
336-
beforeEach(() => {
337-
mocks.useIntersection.mockReturnValue({
338-
isIntersecting: true,
339-
})
340-
})
341-
342-
afterEach(() => {
343-
vi.clearAllMocks()
344-
})
345-
346336
describe('when there is not a next page', () => {
347337
it('does not call fetchNextPage', async () => {
348338
const { user, fetchNextPage } = setup({ hasNextPage: false })
@@ -359,12 +349,12 @@ describe('CommitsTab', () => {
359349

360350
describe('when there is a next page', () => {
361351
it('calls fetchNextPage', async () => {
362-
const { fetchNextPage, user } = setup({ hasNextPage: true })
352+
const { fetchNextPage } = setup({ hasNextPage: true })
353+
mocks.useIntersection.mockReturnValue({
354+
isIntersecting: true,
355+
})
363356
render(<CommitsTab />, { wrapper })
364357

365-
const select = await screen.findByText('Select branch')
366-
await user.click(select)
367-
368358
await waitFor(() =>
369359
expect(fetchNextPage).toHaveBeenCalledWith('some cursor')
370360
)

src/pages/RepoPage/CoverageTab/OverviewTab/Summary/Summary.test.jsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ describe('Summary', () => {
363363
describe('there is a next page', () => {
364364
it('calls fetchNextPage', async () => {
365365
const mockSetNewPath = vi.fn()
366-
const { fetchNextPage, user } = setup({
366+
const { fetchNextPage } = setup({
367367
hasNextPage: true,
368368
coverageRedirectData: {
369369
redirectState: {
@@ -378,11 +378,6 @@ describe('Summary', () => {
378378
})
379379
render(<Summary />, { wrapper: wrapper() })
380380

381-
const select = await screen.findByRole('button', {
382-
name: 'select branch',
383-
})
384-
await user.click(select)
385-
386381
await waitFor(() => expect(fetchNextPage).toHaveBeenCalled())
387382
})
388383
})

src/pages/RepoPage/CoverageTab/OverviewTab/SummaryTeamPlan/SummaryTeamPlan.test.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ describe('Summary', () => {
348348
describe('there is a next page', () => {
349349
it('calls fetchNextPage', async () => {
350350
const mockSetNewPath = vi.fn()
351-
const { fetchNextPage, user } = setup({
351+
const { fetchNextPage } = setup({
352352
isIntersecting: true,
353353
hasNextPage: true,
354354
coverageRedirectData: {
@@ -361,11 +361,6 @@ describe('Summary', () => {
361361
})
362362
render(<SummaryTeamPlan />, { wrapper: wrapper() })
363363

364-
const select = await screen.findByRole('button', {
365-
name: 'select branch',
366-
})
367-
await user.click(select)
368-
369364
await waitFor(() => expect(fetchNextPage).toHaveBeenCalled())
370365
})
371366
})

src/ui/FileViewer/ToggleHeader/ToggleHeader.test.tsx

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,6 @@ import { MemoryRouter, Route } from 'react-router-dom'
66

77
import ToggleHeader from './ToggleHeader'
88

9-
const mocks = vi.hoisted(() => ({
10-
useIntersection: vi.fn(),
11-
}))
12-
13-
vi.mock('react-use', async () => {
14-
const original = await vi.importActual('react-use')
15-
16-
return {
17-
...original,
18-
useIntersection: mocks.useIntersection,
19-
}
20-
})
21-
229
const mockFlagResponse = {
2310
owner: {
2411
repository: {

0 commit comments

Comments
 (0)