Skip to content

Commit d20077c

Browse files
authored
feat: Tweak header and add tooltip on flags table coverage (#3913)
1 parent 5f3314c commit d20077c

File tree

2 files changed

+34
-2
lines changed

2 files changed

+34
-2
lines changed

src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ describe('FlagsTable', () => {
252252
const flags = await screen.findByText('Flags')
253253
expect(flags).toBeInTheDocument()
254254

255-
const coverage = await screen.findByText('Coverage %')
255+
const coverage = await screen.findByText('Average coverage %')
256256
expect(coverage).toBeInTheDocument()
257257

258258
const trend = await screen.findByText('Trend')

src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import A from 'ui/A'
1818
import CoverageProgress from 'ui/CoverageProgress'
1919
import Icon from 'ui/Icon'
2020
import Spinner from 'ui/Spinner'
21+
import { Tooltip } from 'ui/Tooltip'
2122

2223
import DeleteFlagModal from './DeleteFlagModal'
2324
import useRepoFlagsTable from './hooks'
@@ -38,7 +39,38 @@ const columns = [
3839
cell: ({ renderValue }) => renderValue(),
3940
}),
4041
columnHelper.accessor('coverage', {
41-
header: () => 'Coverage %',
42+
header: () => (
43+
<div className="flex items-center gap-1">
44+
Average coverage %
45+
<Tooltip delayDuration={0} skipDelayDuration={100}>
46+
<Tooltip.Root>
47+
<Tooltip.Trigger>
48+
<div className="text-ds-gray-tertiary dark:text-ds-gray-quinary">
49+
<Icon name="informationCircle" size="sm" />
50+
</div>
51+
</Tooltip.Trigger>
52+
<Tooltip.Portal>
53+
<Tooltip.Content
54+
side="right"
55+
className="w-64 rounded-md bg-ds-gray-primary p-3 text-xs text-ds-gray-octonary"
56+
>
57+
This is the average flag coverage over the selected time period.
58+
To view current coverage % for a given flag, navigate to the{' '}
59+
<A
60+
to={{ pageName: 'overview' }}
61+
hook="overview-tab"
62+
isExternal={false}
63+
>
64+
Overview tab
65+
</A>{' '}
66+
and filter by flag.
67+
<Tooltip.Arrow className="size-4 fill-gray-100" />
68+
</Tooltip.Content>
69+
</Tooltip.Portal>
70+
</Tooltip.Root>
71+
</Tooltip>
72+
</div>
73+
),
4274
cell: ({ renderValue }) => renderValue(),
4375
enableSorting: false,
4476
}),

0 commit comments

Comments
 (0)