Skip to content

Commit ecdafdb

Browse files
[fix] +- Change appearing for a PR (#3619)
Co-authored-by: sentry-autofix[bot] <157164994+sentry-autofix[bot]@users.noreply.github.com>
1 parent 0e9f64a commit ecdafdb

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

src/ui/TotalsNumber/TotalsNumber.test.tsx

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,25 @@ describe('TotalsNumber', () => {
137137

138138
const changeValue = screen.getByTestId('change-value')
139139
expect(changeValue).toHaveTextContent('0')
140+
expect(changeValue).not.toHaveClass("before:content-['+']")
141+
142+
const numberValue = screen.getByTestId('number-value')
143+
expect(numberValue).toHaveClass('bg-ds-coverage-covered')
144+
})
145+
146+
it('does not render + sign for zero value', () => {
147+
render(
148+
<TotalsNumber
149+
value={0}
150+
variant="default"
151+
showChange
152+
data-testid="change-value"
153+
/>
154+
)
155+
156+
const changeValue = screen.getByTestId('change-value')
157+
expect(changeValue).toHaveTextContent('0')
158+
expect(changeValue).not.toHaveClass("before:content-['+']")
140159

141160
const numberValue = screen.getByTestId('number-value')
142161
expect(numberValue).toHaveClass('bg-ds-coverage-covered')

src/ui/TotalsNumber/TotalsNumber.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const getNumberClasses = ({
2828
hasValue && parseFloat(value.toFixed(2)) < 0 && !plain,
2929
'bg-ds-coverage-covered':
3030
hasValue && parseFloat(value.toFixed(2)) >= 0 && !plain,
31-
"before:content-['+']": hasValue && showChange,
31+
"before:content-['+']": hasValue && showChange && value > 0,
3232
})
3333
}
3434

0 commit comments

Comments
 (0)