fix or ignore print statements (#486)

ajay-sentry · web-flow · commit 8db93ad95f38 · 2025-01-24T17:31:41.000Z
diff --git a/ruff.toml b/ruff.toml
@@ -36,9 +36,9 @@ indent-width = 4
 target-version = "py312"
 
 [lint]
-# Currently only enabled for F (Pyflakes), I (isort), E,W (pycodestyle:Error/Warning), PLC/PLE/PLW (Pylint:Convention/Error/Warning) 
-# and PERF (Perflint) rules: https://docs.astral.sh/ruff/rules/
-select = ["F", "I", "E", "W", "PLC", "PLE", "PLW", "PERF"]
+# Currently only enabled for F (Pyflakes), I (isort), E,W (pycodestyle:Error/Warning), PLC/PLE/PLW (Pylint:Convention/Error/Warning),
+# PERF (Perflint), and T20 (Flake8-print) rules: https://docs.astral.sh/ruff/rules/
+select = ["F", "I", "E", "W", "PLC", "PLE", "PLW", "PERF", "T20"]
 ignore = ["F403", "F405", "E501", "E712"]
 
 # Allow fix for all enabled rules (when `--fix`) is provided.
diff --git a/shared/django_apps/reports/migrations/0019_auto_20240424_1824.py b/shared/django_apps/reports/migrations/0019_auto_20240424_1824.py
@@ -24,7 +24,7 @@ class Migration(migrations.Migration):
     ]
 
     def populate_test_instances(apps, schema_editor):
-        print("Not running due to performance")
+        print("Not running due to performance")  # noqa: T201
         return
         TestInstance = apps.get_model("reports", "TestInstance")
 
diff --git a/shared/license/__init__.py b/shared/license/__init__.py
@@ -100,4 +100,4 @@ def startup_license_logging():
 
         # printing the message in a single statement so the lines won't get split up
         # among all the other messages during startup
-        print(*statements_to_print, sep="\n")
+        print(*statements_to_print, sep="\n")  # noqa: T201
diff --git a/shared/storage/minio.py b/shared/storage/minio.py
@@ -246,7 +246,7 @@ def delete_files(self, bucket_name: str, paths: list[str]) -> list[bool]:
             for del_err in self.minio_client.remove_objects(
                 bucket_name, [DeleteObject(path) for path in paths]
             ):
-                print("Deletion error: {}".format(del_err))
+                print("Deletion error: {}".format(del_err))  # noqa: T201
             return [True] * len(paths)
         except MinioException:
             raise
diff --git a/shared/storage/new_minio.py b/shared/storage/new_minio.py
@@ -310,7 +310,7 @@ def delete_files(self, bucket_name, urls=[]):
             for del_err in self.minio_client.remove_objects(
                 bucket_name, [DeleteObject(url) for url in urls]
             ):
-                print("Deletion error: {}".format(del_err))
+                print("Deletion error: {}".format(del_err))  # noqa: T201
             return [True] * len(urls)
         except MinioException:
             raise
diff --git a/tests/integration/test_bitbucket.py b/tests/integration/test_bitbucket.py
@@ -525,7 +525,6 @@ async def test_get_compare(self, valid_handler, codecov_vcr):
             "commits": [{"commitid": "b92edba"}, {"commitid": "6ae5f17"}],
         }
         res = await valid_handler.get_compare(base, head)
-        print(res)
         assert sorted(list(res.keys())) == sorted(list(expected_result.keys()))
         assert res == expected_result
 
@@ -1043,7 +1042,6 @@ async def test_list_repos_no_username(self, valid_handler, codecov_vcr):
             }
         ]
         res = await valid_handler.list_repos()
-        print(res)
         assert sorted(res, key=lambda x: x["repo"]["service_id"]) == sorted(
             expected_result, key=lambda x: x["repo"]["service_id"]
         )
@@ -1089,7 +1087,6 @@ async def test_list_teams(self, valid_handler, codecov_vcr):
             },
         ]
         res = await valid_handler.list_teams()
-        print(res)
         assert res == expected_result
 
     @pytest.mark.asyncio
diff --git a/tests/integration/test_gitlab.py b/tests/integration/test_gitlab.py
@@ -316,7 +316,6 @@ async def test_get_commit_diff(self, valid_handler, codecov_vcr):
         res = await valid_handler.get_commit_diff(
             "c739768fcac68144a3a6d82305b9c4106934d31a"
         )
-        print(list(res.keys()))
         assert res == expected_result
 
     @pytest.mark.asyncio
@@ -364,7 +363,6 @@ async def test_set_commit_status(self, valid_handler, codecov_vcr):
     @pytest.mark.asyncio
     async def test_get_branches(self, valid_handler, codecov_vcr):
         branches = sorted(await valid_handler.get_branches())
-        print(branches)
         assert list(map(lambda a: a[0], branches)) == ["main", "other-branch"]
 
     @pytest.mark.asyncio
@@ -374,7 +372,6 @@ async def test_get_branch(self, valid_handler, codecov_vcr):
             "sha": "0fc784af11c401449e56b24a174bae7b9af86c98",
         }
         branch = await valid_handler.get_branch("main")
-        print(branch)
         assert branch == expected_result
 
     @pytest.mark.asyncio
@@ -507,7 +504,6 @@ async def test_get_compare(self, valid_handler, codecov_vcr):
             ],
         }
         res = await valid_handler.get_compare(base, head)
-        print(res)
         assert sorted(list(res.keys())) == sorted(list(expected_result.keys()))
         for key in res:
             assert res[key] == expected_result[key]
diff --git a/tests/unit/reports/samples/test_filtered.py b/tests/unit/reports/samples/test_filtered.py
@@ -866,7 +866,6 @@ def test_apply_diff_not_saving(self, sample_report):
         }
 
     def test_network(self, sample_report):
-        print(list(sample_report.filter(paths=[".*go"]).network))
         assert list(sample_report.filter(paths=[".*go"]).network) == [
             (
                 "file_1.go",
diff --git a/tests/unit/reports/test_carryforward.py b/tests/unit/reports/test_carryforward.py
@@ -1,5 +1,4 @@
 import dataclasses
-import pprint
 from json import loads
 
 import pytest
@@ -400,7 +399,6 @@ def test_generate_carryforward_report_one_file_not_covered(self, sample_report):
         assert res.files == ["file_1.go"]
         readable_report = self.convert_report_to_better_readable(res)
 
-        pprint.pprint(readable_report)
         expected_result = {
             "archive": {
                 "file_1.go": [
@@ -473,7 +471,6 @@ def test_generate_carryforward_report_session_extras(self, sample_report):
         assert res.files == ["file_1.go"]
         readable_report = self.convert_report_to_better_readable(res)
 
-        pprint.pprint(readable_report)
         expected_result = {
             "archive": {
                 "file_1.go": [
diff --git a/tests/unit/reports/test_changes.py b/tests/unit/reports/test_changes.py
@@ -83,7 +83,6 @@ def test_run_comparison_using_rust(sample_rust_report):
         }
     }
     k = run_comparison_using_rust(base_report, head_report, diff)
-    print(k)
     assert k == {
         "files": [
             {
@@ -154,7 +153,6 @@ def test_get_changes_using_rust(sample_rust_report):
         }
     }
     k = get_changes_using_rust(base_report, head_report, diff)
-    print(k)
     assert k == [
         Change(
             path="tests/__init__.py",
@@ -532,5 +530,4 @@ def test_rustify_diff_new_file(self):
                 [((43, 7, 43, 7), [" ", " ", " ", "-", "+", " ", " ", " "])],
             ),
         }
-        print(rustify_diff(user_input))
         assert rustify_diff(user_input) == expected_result
diff --git a/tests/unit/reports/test_editable.py b/tests/unit/reports/test_editable.py
@@ -1887,8 +1887,6 @@ def test_delete_labels(self, sample_with_labels_report):
                 if line.datapoints:
                     for dp in line.datapoints:
                         assert dp.sessionid != 0 or 3 not in dp.label_ids
-        print(sample_with_labels_report)
-        print(sample_with_labels_report._files)
         res = self.convert_report_to_better_readable(sample_with_labels_report)
         expected_result = {
             "totals": {
diff --git a/tests/unit/reports/test_readonly.py b/tests/unit/reports/test_readonly.py
@@ -203,8 +203,6 @@ def test_create_from_report(self, sample_report, mocker, report_header):
 
     def test_get_file_totals(self, sample_report, mocker):
         r = ReadOnlyReport.create_from_report(sample_report)
-        print(sample_report._files)
-        print(r)
         assert r.get_file_totals("location/file_1.py") == ReportTotals(
             files=0,
             lines=2,
diff --git a/tests/unit/reports/test_types.py b/tests/unit/reports/test_types.py
@@ -120,7 +120,6 @@ def test_networkfile_as_tuple(self):
             ),
             diff_totals=None,
         )
-        print(network_file.astuple())
         assert network_file.astuple() == (
             (0, 0, -2, 1, 0, -23.333330000000004, 0, 0, 0, 0, 0, 0, 0),
             None,
diff --git a/tests/unit/torngit/test_github_enterprise.py b/tests/unit/torngit/test_github_enterprise.py
@@ -140,14 +140,11 @@ async def test_make_http_call_change_host(self, mocker, mock_configuration):
         await gl.make_http_call(client, method, url, **query_params)
         assert client.request.call_count == 1
         args, kwargs = client.request.call_args
-        print(args)
-        print(kwargs)
         assert kwargs.get("headers") is not None
         assert kwargs.get("headers").get("Host") == "ghe.com"
         assert len(args) == 2
         built_url = args[1]
         parsed_url = urlparse(built_url)
-        print(parsed_url)
         assert parsed_url.scheme == "https"
         assert parsed_url.netloc == mock_host
         assert parsed_url.path == "/random_url"
diff --git a/tests/unit/torngit/test_gitlab_enterprise.py b/tests/unit/torngit/test_gitlab_enterprise.py
@@ -11,7 +11,6 @@ def test_redirect_uri(self, mocker):
         assert gle.redirect_uri == "https://codecov.io/login/gle"
 
         def custom_config(*args, **kwargs):
-            print(args)
             if args == ("gitlab_enterprise", "redirect_uri"):
                 return "https://custom_redirect.com"
             if args == ("setup", "codecov_url"):
@@ -26,7 +25,6 @@ def custom_config(*args, **kwargs):
         )
 
         def custom_config(*args, **kwargs):
-            print(args)
             if args == ("gitlab", "redirect_uri"):
                 return None
             if args == ("setup", "codecov_url"):
diff --git a/tests/unit/validation/test_helpers.py b/tests/unit/validation/test_helpers.py
@@ -261,7 +261,6 @@ def test_translate_glob_to_regex(self):
             re.compile(translate_glob_to_regex("**/test*.ts")).match("src/src2/test.ts")
             is not None
         )
-        print(f'"a/*/*b*.ts" => {translate_glob_to_regex("a/*/*b*.ts")}')
         assert (
             re.compile(translate_glob_to_regex("a/*/*b*.ts")).match("a/folder/b.ts")
             is not None
@@ -285,7 +284,6 @@ def test_translate_glob_to_regex(self):
             )
             is None
         )
-        print(f'"a/**/*b*.ts" => {translate_glob_to_regex("a/**/*b*.ts")}')
         assert (
             re.compile(translate_glob_to_regex("a/**/*b*.ts")).match("a/folder/b.ts")
             is not None
diff --git a/tests/unit/validation/test_install_validation.py b/tests/unit/validation/test_install_validation.py
@@ -338,7 +338,6 @@ def test_validate_sample_production_config(mocker):
     }
     mock_warning = mocker.patch.object(install_log, "warning")
     res = validate_install_configuration(user_input)
-    print(mock_warning.call_args)
     assert mock_warning.call_count == 0
     assert res["site"] == expected_result["site"]
     assert res == expected_result

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class Migration(migrations.Migration):`
`24`	`24`	`]`
`25`	`25`
`26`	`26`	`def populate_test_instances(apps, schema_editor):`
`27`		`- print("Not running due to performance")`
	`27`	`+ print("Not running due to performance") # noqa: T201`
`28`	`28`	`return`
`29`	`29`	`TestInstance = apps.get_model("reports", "TestInstance")`
`30`	`30`
Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,6 @@ async def test_get_compare(self, valid_handler, codecov_vcr):`
`525`	`525`	`"commits": [{"commitid": "b92edba"}, {"commitid": "6ae5f17"}],`
`526`	`526`	`}`
`527`	`527`	`res = await valid_handler.get_compare(base, head)`
`528`		`- print(res)`
`529`	`528`	`assert sorted(list(res.keys())) == sorted(list(expected_result.keys()))`
`530`	`529`	`assert res == expected_result`
`531`	`530`
`@@ -1043,7 +1042,6 @@ async def test_list_repos_no_username(self, valid_handler, codecov_vcr):`
`1043`	`1042`	`}`
`1044`	`1043`	`]`
`1045`	`1044`	`res = await valid_handler.list_repos()`
`1046`		`- print(res)`
`1047`	`1045`	`assert sorted(res, key=lambda x: x["repo"]["service_id"]) == sorted(`
`1048`	`1046`	`expected_result, key=lambda x: x["repo"]["service_id"]`
`1049`	`1047`	`)`
`@@ -1089,7 +1087,6 @@ async def test_list_teams(self, valid_handler, codecov_vcr):`
`1089`	`1087`	`},`
`1090`	`1088`	`]`
`1091`	`1089`	`res = await valid_handler.list_teams()`
`1092`		`- print(res)`
`1093`	`1090`	`assert res == expected_result`
`1094`	`1091`
`1095`	`1092`	`@pytest.mark.asyncio`
Original file line number	Diff line number	Diff line change
`@@ -866,7 +866,6 @@ def test_apply_diff_not_saving(self, sample_report):`
`866`	`866`	`}`
`867`	`867`
`868`	`868`	`def test_network(self, sample_report):`
`869`		`- print(list(sample_report.filter(paths=[".*go"]).network))`
`870`	`869`	`assert list(sample_report.filter(paths=[".*go"]).network) == [`
`871`	`870`	`(`
`872`	`871`	`"file_1.go",`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ def test_run_comparison_using_rust(sample_rust_report):`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`	`k = run_comparison_using_rust(base_report, head_report, diff)`
`86`		`- print(k)`
`87`	`86`	`assert k == {`
`88`	`87`	`"files": [`
`89`	`88`	`{`
`@@ -154,7 +153,6 @@ def test_get_changes_using_rust(sample_rust_report):`
`154`	`153`	`}`
`155`	`154`	`}`
`156`	`155`	`k = get_changes_using_rust(base_report, head_report, diff)`
`157`		`- print(k)`
`158`	`156`	`assert k == [`
`159`	`157`	`Change(`
`160`	`158`	`path="tests/__init__.py",`
`@@ -532,5 +530,4 @@ def test_rustify_diff_new_file(self):`
`532`	`530`	`[((43, 7, 43, 7), [" ", " ", " ", "-", "+", " ", " ", " "])],`
`533`	`531`	`),`
`534`	`532`	`}`
`535`		`- print(rustify_diff(user_input))`
`536`	`533`	`assert rustify_diff(user_input) == expected_result`