fix: new TA cutoff date logic (#253)

* fix: new TA cutoff date logic

* fix: rename

Author: joseph-sentry

apps/worker/tasks/tests/unit/test_upload_task.py

@@ -507,6 +507,18 @@ def test_upload_task_call_new_ta_tasks(
         dbsession.flush()
         dbsession.refresh(commit)
 
+        mock_repo_provider_service.get_commit.return_value = {
+            "author": {
+                "id": "123",
+                "username": "456",
+                "email": "789",
+                "name": "101",
+            },
+            "message": "hello world",
+            "parents": [],
+            "timestamp": str(NEW_TA_TASKS_CUTOFF_DATE - timedelta(days=10)),
+        }
+
         mock_redis.lists[f"uploads/{commit.repoid}/{commit.commitid}/test_results"] = (
             jsonified_redis_queue
         )

apps/worker/tasks/upload.py

@@ -756,18 +756,17 @@ def _schedule_ta_processing_task(
             new_ta_tasks = "old"
         else:
             db_session: Session = commit.get_db_session()  # type: ignore
-            earliest_commit = (
+            commit_before_cutoff = (
                 db_session.query(Commit)
                 .filter(
                     Commit.repoid == commit.repoid,
-                    Commit.timestamp > NEW_TA_TASKS_CUTOFF_DATE,
+                    Commit.timestamp < NEW_TA_TASKS_CUTOFF_DATE,
                 )
-                .order_by(Commit.timestamp)
                 .limit(1)
                 .first()
             )
 
-            if earliest_commit:
+            if commit_before_cutoff is None:
                 new_ta_tasks = "new"
                 new_ta_tasks_repo_summary.inc()