fix: run type-check and correct invalid calls

Author: drazisil-codecov

bin/codecov

@@ -123,7 +123,7 @@ app
     app.verbose(`End of uploader: ${end - start} milliseconds`, argv.verbose)
   })
   .catch(error => {
-    app.log(`Error!: ${error}`, { level: 'error', argv })
+    app.error(`Error!: ${error}`)
     const end = Date.now()
     app.verbose(`End of uploader: ${end - start} milliseconds`, argv.verbose)
     process.exit(argv.nonZero ? -1 : 0)

src/helpers/files.js

@@ -196,6 +196,7 @@ function fetchGitRoot() {
     ).trimRight()
   } catch (error) {
     logAndThrow('Error fetching git root. Please try using the -R flag.')
+    return '.'
   }
 }
 
@@ -206,7 +207,8 @@ function fetchGitRoot() {
  */
 function parseGitIgnore(projectRoot) {
   const gitIgnorePath = path.join(projectRoot, '.gitignore')
-  let lines
+  /** @type {string[]} */
+  let lines = []
   try {
     lines = readAllLines(gitIgnorePath) || []
   } catch (error) {
@@ -226,6 +228,7 @@ function parseGitIgnore(projectRoot) {
  * @param {string} projectRoot Root of the project
  * @param {string} dirPath Directory to search in
  * @param {Object} args
+ * @param {boolean} [args.verbose]
  * @param {string[]} arrayOfFiles
  * @returns {string[]}
  */
@@ -280,6 +283,7 @@ function readCoverageFile(projectRoot, filePath) {
   } catch (error) {
     logAndThrow(`There was an error reading the coverage file: ${error}`)
   }
+  return ''
 }
 
 function endNetworkMarker() {

src/index.js

@@ -93,7 +93,7 @@ async function main(args) {
 
   if (!args.feature || args.feature.split(',').includes('network') === false) {
     verbose('Start of network processing...', args.verbose)
-    let fileListing
+    let fileListing = ''
     try {
       fileListing = await fileHelpers.getFileListing(projectRoot, args)
     } catch (error) {
@@ -199,6 +199,7 @@ async function main(args) {
 
   if (serviceParams === undefined) {
     logAndThrow('Unable to detect service, please specify manually.')
+    process.exit(args.nonZero ? -1 : 0)
   }
 
   // == Step 8: either upload or dry-run
@@ -218,14 +219,14 @@ async function main(args) {
   )
   verbose(`Passed token was ${token.length} characters long`, args.verbose)
   try {
-    info(
+    verbose(
       `${uploadHost}/upload/v4?package=${webHelpers.getPackage(
         args.source,
       )}&${query}
         Content-Type: 'text/plain'
         Content-Encoding: 'gzip'
         X-Reduced-Redundancy: 'false'`,
-      { level: 'debug', args },
+      args.verbose,
     )
 
     const uploadURL = await webHelpers.uploadToCodecov(