Refactor getCoverageFiles

Author: RA80533

src/helpers/files.js

@@ -1,7 +1,7 @@
 // @ts-check
 const childProcess = require('child_process')
+const glob = require('fast-glob')
 const fs = require('fs')
-const glob = require('glob')
 const path = require('path').posix
 const { logAndThrow } = require('./util')
 const { error, info, verbose } = require('./logger')
@@ -160,15 +160,14 @@ function coverageFilePatterns() {
  *
  * @param {string} projectRoot
  * @param {string[]} coverageFilePatterns
- * @returns {string[]}
+ * @returns {Promise<string[]>}
  */
-function getCoverageFiles(projectRoot, coverageFilePatterns) {
-  return coverageFilePatterns.flatMap(
-    /** @type {string} */ pattern => {
-      return glob.sync(`**/${pattern}`, {
-        cwd: projectRoot,
-        ignore: globBlacklist(),
-      })
+async function getCoverageFiles(projectRoot, coverageFilePatterns) {
+  return glob(
+    coverageFilePatterns.map(pattern => `**/${pattern}`),
+    {
+      cwd: projectRoot,
+      ignore: globBlacklist(),
     },
   )
 }

test/helpers/files.test.js

@@ -81,8 +81,8 @@ describe('File Helpers', () => {
       expect(reportContents).toBe('I am test coverage data')
     })
 
-    it('can return a list of coverage files', () => {
-      const results = fileHelpers.getCoverageFiles(
+    it('can return a list of coverage files', async () => {
+      const results = await fileHelpers.getCoverageFiles(
         '.',
         fileHelpers.coverageFilePatterns(),
       )
@@ -94,9 +94,9 @@ describe('File Helpers', () => {
       expect(results).toContain('test/fixtures/other/fake.codecov.txt')
     })
 
-    it('can return a list of coverage files with a pattern', () => {
+    it('can return a list of coverage files with a pattern', async () => {
       expect(
-        fileHelpers.getCoverageFiles('.', ['index.test.js']),
+        await fileHelpers.getCoverageFiles('.', ['index.test.js']),
       ).toStrictEqual(['test/index.test.js', 'test/providers/index.test.js'])
     })
     describe('coverage file patterns', () => {