makefile changes for monorepo prep

[matt-codecov]

needed for codecov/umbrella#4

we bindmount our local worker into the docker container. currently our local worker is the actual git repo, so the git invocation works. in umbrella, it's not the actual git repo, so the command fails

apparently this is all i need to change...?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (4229dee) to head (46b91bb).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         454      454           
  Lines       37362    37362           
=======================================
  Hits        36341    36341           
  Misses       1021     1021           

Flag	Coverage Δ
integration	43.14% <ø> (ø)
unit	89.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[Swatinem]

First time I hear about this setting, so I looked it up:

These config entries specify Git-tracked directories that are considered safe even if they are owned by someone other than the current user. By default, Git will refuse to even parse a Git config of a repository owned by someone else, let alone run its hooks […]

This makes total sense. But I also wonder why we need git access at all within the container?

Do you know what would happen if we just remove this, along with the apt-get install git above?

[matt-codecov]

This makes total sense. But I also wonder why we need git access at all within the container?

until recently (codecov/gha-workflows#42) we invoked the CLI inside the container which uses git for a few things. we no longer do that, but i tried to delete this line and it fatally failed. honestly don't know why but i am reasonably confident that it doesn't matter so i ignore the failure here

in umbrella i'd like to try using a repo-wide lockfile and sharing more docker stuff, so was gonna punt until then to figure this out