fix: handle spaces and quotes in args

the previous iteration was not properly handling spaces in arguments
that users would pass and in the eval that runs the codecov command,
those args would get split by their spaces, so now we quote the
arguments and we escape whatever quotes they may contain.

Author: joseph-sentry

.github/workflows/ci.yml

@@ -23,6 +23,7 @@ jobs:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
           CODECOV_FAIL_ON_ERROR: true
           CODECOV_FLAGS: flag1,flag2
+          CODECOV_NAME: 'Ubuntu: Test''s "CI & Build" Job'
 
   test-macos:
     runs-on: macos-latest
@@ -43,6 +44,7 @@ jobs:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
           CODECOV_FAIL_ON_ERROR: true
           CODECOV_FLAGS: flag1,flag2
+          CODECOV_NAME: 'macOS: Test''s "CI & Build" Job'
 
   test-windows:
     runs-on: windows-latest
@@ -66,6 +68,7 @@ jobs:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
           CODECOV_FAIL_ON_ERROR: true
           CODECOV_FLAGS: flag1,flag2
+          CODECOV_NAME: 'Windows: Test''s "CI & Build" Job'
 
   test-alpine:
     runs-on: ubuntu-latest
@@ -86,6 +89,7 @@ jobs:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
           CODECOV_FAIL_ON_ERROR: true
           CODECOV_FLAGS: flag1,flag2
+          CODECOV_NAME: 'Alpine: Test''s "CI & Build" Job'
 
   shellcheck:
     runs-on: ubuntu-latest

dist/codecov.sh

@@ -32,8 +32,12 @@ write_bool_args() {
     echo "-$(lower $1)"
   fi
 }
-add_cli_arg() { [ -n "$1" ] && CODECOV_CLI_ARGS="${CODECOV_CLI_ARGS:+$CODECOV_CLI_ARGS }$1"; }
-add_arg() { [ -n "$1" ] && CODECOV_ARGS="${CODECOV_ARGS:+$CODECOV_ARGS }$1"; }
+quote_arg() {
+  escaped=$(printf '%s\n' "$1" | sed "s/'/'\\\\''/g")
+  printf "'%s'" "$escaped"
+}
+add_cli_arg() { [ -n "$1" ] && CODECOV_CLI_ARGS="${CODECOV_CLI_ARGS:+$CODECOV_CLI_ARGS }$(quote_arg "$1")"; }
+add_arg() { [ -n "$1" ] && CODECOV_ARGS="${CODECOV_ARGS:+$CODECOV_ARGS }$(quote_arg "$1")"; }
 b="\033[0;36m"  # variables/constants
 g="\033[0;32m"  # info/debug
 r="\033[0;31m"  # errors

scripts/set_funcs.sh

@@ -39,8 +39,12 @@ write_bool_args() {
   fi
 }
 
-add_cli_arg() { [ -n "$1" ] && CODECOV_CLI_ARGS="${CODECOV_CLI_ARGS:+$CODECOV_CLI_ARGS }$1"; }
-add_arg() { [ -n "$1" ] && CODECOV_ARGS="${CODECOV_ARGS:+$CODECOV_ARGS }$1"; }
+quote_arg() {
+  escaped=$(printf '%s\n' "$1" | sed "s/'/'\\\\''/g")
+  printf "'%s'" "$escaped"
+}
+add_cli_arg() { [ -n "$1" ] && CODECOV_CLI_ARGS="${CODECOV_CLI_ARGS:+$CODECOV_CLI_ARGS }$(quote_arg "$1")"; }
+add_arg() { [ -n "$1" ] && CODECOV_ARGS="${CODECOV_ARGS:+$CODECOV_ARGS }$(quote_arg "$1")"; }
 
 b="\033[0;36m"  # variables/constants
 g="\033[0;32m"  # info/debug