Skip to content

Commit d2f9af5

Browse files
Merge pull request #26 from codecov/th/fix-name-with-spaces
fix: update CODECOV_NAME to allow spaces
2 parents 25f50b4 + ce1bd32 commit d2f9af5

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

dist/codecov.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,10 @@ cc_du_args+=( $(write_existing_args CC_GIT_SERVICE) )
171171
cc_du_args+=( $(write_truthy_args CC_HANDLE_NO_REPORTS_FOUND) )
172172
cc_du_args+=( $(write_existing_args CC_JOB_CODE) )
173173
cc_du_args+=( $(write_truthy_args CC_LEGACY) )
174-
cc_du_args+=( $(write_existing_args CC_NAME) )
174+
if [ -n "$CC_NAME" ];
175+
then
176+
cc_du_args+=( "--name" "$CC_NAME" )
177+
fi
175178
cc_du_args+=( $(write_existing_args CC_NETWORK_FILTER) )
176179
cc_du_args+=( $(write_existing_args CC_NETWORK_PREFIX) )
177180
cc_du_args+=( $(write_existing_args CC_NETWORK_ROOT_FOLDER) )
@@ -232,7 +235,7 @@ if ! ./$cc_filename \
232235
${cc_cli_args[*]} \
233236
do-upload \
234237
${token_arg[*]} \
235-
${cc_du_args[*]};
238+
"${cc_du_args[@]}";
236239
then
237240
exit_if_error "Failed to upload"
238241
fi

scripts/envs

Whitespace-only changes.

scripts/set_do_upload_args.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@ codecov_du_args+=( $(write_existing_args CODECOV_GIT_SERVICE) )
4646
codecov_du_args+=( $(write_truthy_args CODECOV_HANDLE_NO_REPORTS_FOUND) )
4747
codecov_du_args+=( $(write_existing_args CODECOV_JOB_CODE) )
4848
codecov_du_args+=( $(write_truthy_args CODECOV_LEGACY) )
49-
codecov_du_args+=( $(write_existing_args CODECOV_NAME) )
49+
if [ -n "$CODECOV_NAME" ];
50+
then
51+
codecov_du_args+=( "--name" "$CODECOV_NAME" )
52+
fi
5053
codecov_du_args+=( $(write_existing_args CODECOV_NETWORK_FILTER) )
5154
codecov_du_args+=( $(write_existing_args CODECOV_NETWORK_PREFIX) )
5255
codecov_du_args+=( $(write_existing_args CODECOV_NETWORK_ROOT_FOLDER) )

scripts/upload.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ if ! ./$codecov_filename \
5151
${codecov_cli_args[*]} \
5252
do-upload \
5353
${token_arg[*]} \
54-
${codecov_du_args[*]};
54+
"${codecov_du_args[@]}";
5555
then
5656
exit_if_error "Failed to upload"
5757
fi

0 commit comments

Comments
 (0)