Merge pull request #101 from codecrafters-io/andy/fix

andy1li · web-flow · commit 1acccbe99e70 · 2025-10-28T02:56:26.000+08:00
Improve error message formatting #jt4
diff --git a/internal/stage_create_blob.go b/internal/stage_create_blob.go
@@ -57,7 +57,8 @@ func testCreateBlob(harness *test_case_harness.TestCaseHarness) error {
 	expectedSha := blobObjectVerifier.ExpectedSha()
 
 	if len(strings.TrimSpace(string(result.Stdout))) != 40 {
-		return fmt.Errorf("Expected a 40-char SHA (%q) as output. Got: %q", blobObjectVerifier.ExpectedSha(), strings.TrimSpace(string(result.Stdout)))
+		return fmt.Errorf(`Expected a 40-char SHA: %s
+Got:                    %s`, blobObjectVerifier.ExpectedSha(), strings.TrimSpace(string(result.Stdout)))
 	}
 
 	actualSha := strings.TrimSpace(string(result.Stdout))

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,8 @@ func testCreateBlob(harness *test_case_harness.TestCaseHarness) error {`
`57`	`57`	`expectedSha := blobObjectVerifier.ExpectedSha()`
`58`	`58`
`59`	`59`	`if len(strings.TrimSpace(string(result.Stdout))) != 40 {`
`60`		`- return fmt.Errorf("Expected a 40-char SHA (%q) as output. Got: %q", blobObjectVerifier.ExpectedSha(), strings.TrimSpace(string(result.Stdout)))`
	`60`	+ return fmt.Errorf(`Expected a 40-char SHA: %s
	`61`	+Got: %s`, blobObjectVerifier.ExpectedSha(), strings.TrimSpace(string(result.Stdout)))
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`actualSha := strings.TrimSpace(string(result.Stdout))`