fix: adjust semantic error handling condition in Run API

ryan-gang · ryan-gang · commit c5d1a9872005 · 2025-02-26T17:17:49.000+05:30
Modify the error checking logic to ensure semantic errors are properly handled when resolving statements
diff --git a/internal/lox/api/run_api.go b/internal/lox/api/run_api.go
@@ -16,7 +16,7 @@ func Run(source string) (string, int, string) {
 	parser := lox.NewParser(tokens)
 	statements := parser.Parse(mockStdout, mockStderr)
 	locals, err := lox.Resolve(statements)
-	if err != nil || lox.HadSemanticError {
+	if err != nil && lox.HadSemanticError {
 		return "", 65, err.Error()
 	}
 	lox.Interpret(statements, locals, mockStdout, mockStderr)

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ func Run(source string) (string, int, string) {`
`16`	`16`	`parser := lox.NewParser(tokens)`
`17`	`17`	`statements := parser.Parse(mockStdout, mockStderr)`
`18`	`18`	`locals, err := lox.Resolve(statements)`
`19`		`- if err != nil \|\| lox.HadSemanticError {`
	`19`	`+ if err != nil && lox.HadSemanticError {`
`20`	`20`	`return "", 65, err.Error()`
`21`	`21`	`}`
`22`	`22`	`lox.Interpret(statements, locals, mockStdout, mockStderr)`