- Refactor: BLPOP test cases

- Add: NoResponseTestCase
- Add: markdowns for stage description

Author: UdeshyaDhungana

internal/test_cases/blocking_client_group_test_case.go

@@ -54,7 +54,7 @@ func (t *BlockingClientGroupTestCase) SendBlockingCommands() error {
 func (t *BlockingClientGroupTestCase) AssertResponses(logger *logger.Logger) error {
 	for _, clientWithExpectedResponse := range t.clientsWithExpectedResponses {
 		if clientWithExpectedResponse.Assertion == nil {
-			testCase := NoUnreadDataTestCase{}
+			testCase := NoResponseTestCase{}
 			if err := testCase.Run(clientWithExpectedResponse.Client, logger); err != nil {
 				return err
 			}
@@ -67,6 +67,5 @@ func (t *BlockingClientGroupTestCase) AssertResponses(logger *logger.Logger) err
 			}
 		}
 	}
-
 	return nil
 }

internal/test_cases/no_response_test_case.go

@@ -0,0 +1,18 @@
+package test_cases
+
+import (
+	"fmt"
+
+	resp_connection "github.com/codecrafters-io/redis-tester/internal/resp/connection"
+	"github.com/codecrafters-io/tester-utils/logger"
+)
+
+type NoResponseTestCase struct{}
+
+func (n *NoResponseTestCase) Run(client *resp_connection.RespConnection, logger *logger.Logger) error {
+	client.ReadIntoBuffer()
+	if client.UnreadBuffer.Len() > 0 {
+		return fmt.Errorf("%s received unexpected response: %q", client.GetIdentifier(), client.UnreadBuffer.String())
+	}
+	return nil
+}

internal/test_cases/send_command_test_case.go

@@ -65,13 +65,9 @@ func (t *SendCommandTestCase) Run(client *resp_client.RespConnection, logger *lo
 		}
 	}
 
-	return t.ProcessResponse(value, client, logger)
-}
-
-func (t *SendCommandTestCase) ProcessResponse(value resp_value.Value, client *resp_client.RespConnection, logger *logger.Logger) error {
 	t.ReceivedResponse = value
 
-	if err := t.Assertion.Run(value); err != nil {
+	if err = t.Assertion.Run(value); err != nil {
 		return err
 	}