Merge pull request #233 from codecrafters-io/andy/add-config-get-dir-response-assertion

Relax dir assertion with a new ConfigGetDirResponseAssertion

Author: andy1li

internal/resp_assertions/config_get_dir_response_assertion.go

@@ -0,0 +1,46 @@
+package resp_assertions
+
+import (
+	"fmt"
+
+	resp_value "github.com/codecrafters-io/redis-tester/internal/resp/value"
+)
+
+type ConfigGetDirResponseAssertion struct {
+	ExpectedDirValue string
+}
+
+func NewConfigGetDirResponseAssertion(expectedDirValue string) RESPAssertion {
+	return ConfigGetDirResponseAssertion{ExpectedDirValue: expectedDirValue}
+}
+
+func (a ConfigGetDirResponseAssertion) Run(value resp_value.Value) error {
+	arrayTypeAssertion := DataTypeAssertion{ExpectedType: resp_value.ARRAY}
+
+	if err := arrayTypeAssertion.Run(value); err != nil {
+		return err
+	}
+
+	if len(value.Array()) != 2 {
+		return fmt.Errorf("Expected 2 elements in array, got %d (%s)", len(value.Array()), value.FormattedString())
+	}
+
+	firstElement := value.Array()[0]
+	secondElement := value.Array()[1]
+
+	if firstElement.Type != resp_value.BULK_STRING {
+		return fmt.Errorf("Expected element #1 to be a bulk string, got %s", firstElement.Type)
+	}
+	if firstElement.String() != "dir" {
+		return fmt.Errorf("Expected element #1 to be %q, got %q", "dir", firstElement.String())
+	}
+
+	if secondElement.Type != resp_value.BULK_STRING {
+		return fmt.Errorf("Expected element #2 to be a bulk string, got %s", secondElement.Type)
+	}
+	if secondElement.String() != a.ExpectedDirValue && secondElement.String() != a.ExpectedDirValue+"/" {
+		return fmt.Errorf("Expected element #2 to be %q, got %q", a.ExpectedDirValue, secondElement.String())
+	}
+
+	return nil
+}

internal/test_rdb_config.go

@@ -38,7 +38,7 @@ func testRdbConfig(stageHarness *test_case_harness.TestCaseHarness) error {
 	commandTestCase := test_cases.SendCommandTestCase{
 		Command:                   "CONFIG",
 		Args:                      []string{"GET", "dir"},
-		Assertion:                 resp_assertions.NewOrderedBulkStringArrayAssertion([]string{"dir", tmpDir}),
+		Assertion:                 resp_assertions.NewConfigGetDirResponseAssertion(tmpDir),
 		ShouldSkipUnreadDataCheck: false,
 	}