refactor: ensure proper mutex handling in SendCommandTestCase

andy1li · andy1li · commit c52cab9d9026 · 2025-05-13T12:17:33.000+08:00
- Added a deferred unlock for the readMutex in the Run method of SendCommandTestCase to ensure that the mutex is always released, preventing potential deadlocks and improving thread safety.
diff --git a/internal/test_cases/send_command_test_case.go b/internal/test_cases/send_command_test_case.go
@@ -42,9 +42,9 @@ func (t *SendCommandTestCase) Run(client *resp_client.RespConnection, logger *lo
 		}
 
 		t.readMutex.Lock()
-		value, err = client.ReadValue()
-		t.readMutex.Unlock()
+		defer t.readMutex.Unlock()
 
+		value, err = client.ReadValue()
 		if err != nil {
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,9 @@ func (t SendCommandTestCase) Run(client resp_client.RespConnection, logger *lo`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`t.readMutex.Lock()`
`45`		`- value, err = client.ReadValue()`
`46`		`- t.readMutex.Unlock()`
	`45`	`+ defer t.readMutex.Unlock()`
`47`	`46`
	`47`	`+ value, err = client.ReadValue()`
`48`	`48`	`if err != nil {`
`49`	`49`	`return err`
`50`	`50`	`}`