Fix a bug with the caseInsensitiveMatch if the space name is false (not a string)

Author: codedread

js/background/background.js

@@ -1401,12 +1401,8 @@ async function requestAllSpaces() {
     const allSessions = await spacesService.getAllSessions();
     /** @type {Space[]} */
     const allSpaces = allSessions
-        .map(session => {
-            return { sessionId: session.id, ...session };
-        })
-        .filter(session => {
-            return session && session.tabs && session.tabs.length > 0;
-        });
+        .map(session => { return { sessionId: session.id, ...session } })
+        .filter(session => session?.tabs?.length > 0);
 
     // sort results
     allSpaces.sort((a, b) => {

js/popup.js

@@ -85,7 +85,11 @@ function routeView(action) {
  */
 
 function renderCommon() {
-    document.getElementById('activeSpaceTitle').value = globalCurrentSpace.name ?? UNSAVED_SESSION;
+    document.getElementById(
+        'activeSpaceTitle'
+    ).value = globalCurrentSpace.name
+            ? globalCurrentSpace.name
+            : UNSAVED_SESSION;
 
     document.querySelector('body').onkeyup = e => {
         // listen for escape key
@@ -219,7 +223,8 @@ export async function handleNameSave() {
     // to check for overwrite, we just let the capitalization change happen.
     // TESTME: Save should occur when the name is a case-insensitive match of the previous name and
     //     the requestSessionPresence message should not be sent.
-    const caseInsensitiveMatch = globalCurrentSpace.name.toLowerCase() === newName.toLowerCase();
+    const caseInsensitiveMatch = globalCurrentSpace?.name
+        && globalCurrentSpace.name.toLowerCase() === newName.toLowerCase();
     const canOverwrite = caseInsensitiveMatch || await checkSessionOverwrite(newName);
     if (!canOverwrite) {
         inputEl.value = globalCurrentSpace.name || UNSAVED_SESSION;

js/spaces.js

@@ -332,7 +332,7 @@ export async function handleNameSave() {
         // name is a case-insensitive match of the previous name, we do not need to check overwrite.
         // TESTME: Save should occur when the name is a case-insensitive match of the previous name and
         //     the requestSessionPresence message should not be sent.
-        const caseInsensitiveMatch = name.toLowerCase() === newName.toLowerCase();
+        const caseInsensitiveMatch = name && name.toLowerCase() === newName.toLowerCase();
         const canOverwrite = caseInsensitiveMatch || await checkSessionOverwrite(newName);
         if (!canOverwrite) {
             updateNameForm(globalSelectedSpace);

manifest.json

@@ -1,7 +1,7 @@
 {
     "name": "Spaces",
     "description": "Intuitive tab management",
-    "version": "1.1.8.1",
+    "version": "1.1.8.2",
     "permissions": [
         "contextMenus",
         "downloads",