Refactor spacesRenderer functions to be module-level exported: getTabDetailsString() and getDefaultSpaceTitle() and add unit tests for them.

Author: codedread

CHANGELOG.md

@@ -10,4 +10,4 @@ All notable changes to this project will be documented in this file.
 -   Updated all code to modern JavaScript and improved documentation.
 -   Fixed [issue #3](https://github.com/codedread/spaces/issues/3) by escaping
     HTML for all extension content.
--   Increased unit test coverage from 0% to 7.51%.
+-   Increased unit test coverage from 0% to ???%.

js/spacesRenderer.js

@@ -1,5 +1,27 @@
 import { escapeHtml } from './utils.js';
 
+export function getDefaultSpaceTitle(space) {
+    const count = space.tabs && space.tabs.length;
+    if (!count) return '';
+    const firstTitle = space.tabs[0].title;
+    if (count === 1) {
+        return `[${escapeHtml(firstTitle)}]`;
+    }
+    return firstTitle.length > 30
+        ? `[${escapeHtml(firstTitle.slice(0, 21))}…] +${count - 1} more`
+        : `[${escapeHtml(firstTitle)}] +${count - 1} more`;
+}
+
+export function getTabDetailsString(space) {
+    const count = space.tabs && space.tabs.length;
+    const open = space.windowId;
+
+    if (open) {
+        return '';
+    }
+    return `(${count} tab${count !== 1 ? 's' : ''})`;
+}
+
 // eslint-disable-next-line no-var
 export const spacesRenderer = {
     nodes: {},
@@ -56,8 +78,8 @@ export const spacesRenderer = {
         listDetail.className = 'spaceDetail';
 
         listTitle.innerHTML =
-            space.name || spacesRenderer.getDefaultSpaceTitle(space);
-        listDetail.innerHTML = spacesRenderer.getTabDetailsString(space);
+            space.name || getDefaultSpaceTitle(space);
+        listDetail.innerHTML = getTabDetailsString(space);
 
         listContainer.appendChild(listTitle);
         listContainer.appendChild(listDetail);
@@ -147,28 +169,6 @@ export const spacesRenderer = {
         }
     },
 
-    getDefaultSpaceTitle(space) {
-        const count = space.tabs && space.tabs.length;
-        if (!count) return '';
-        const firstTitle = space.tabs[0].title;
-        if (count === 1) {
-            return `[${escapeHtml(firstTitle)}]`;
-        }
-        return firstTitle.length > 30
-            ? `[${escapeHtml(firstTitle.slice(0, 21))}…] +${count - 1} more`
-            : `[${escapeHtml(firstTitle)}] +${count - 1} more`;
-    },
-
-    getTabDetailsString(space) {
-        const count = space.tabs && space.tabs.length;
-        const open = space.windowId;
-
-        if (open) {
-            return '';
-        }
-        return `(${count} tab${count > 1 ? 's' : ''})`;
-    },
-
     updateSpacesList() {
         const query = spacesRenderer.nodes.moveInput.value;
         let match = false;

tests/getDefaultSpaceTitle.test.js

@@ -0,0 +1,33 @@
+import { getDefaultSpaceTitle } from '../js/spacesRenderer.js';
+
+describe('getDefaultSpaceTitle', () => {
+    test('should return an empty string if there are no tabs', () => {
+        const space = { tabs: [] };
+        expect(getDefaultSpaceTitle(space)).toBe('');
+    });
+
+    test('should return the title of the single tab', () => {
+        const space = { tabs: [{ title: 'Test Tab' }] };
+        expect(getDefaultSpaceTitle(space)).toBe('[Test Tab]');
+    });
+
+    test('should return the title of the first tab and a count of the others', () => {
+        const space = { tabs: [{ title: 'Test Tab' }, { title: 'Another Tab' }] };
+        expect(getDefaultSpaceTitle(space)).toBe('[Test Tab] +1 more');
+    });
+
+    test('should truncate long titles', () => {
+        const space = {
+            tabs: [
+                { title: 'This is a very long tab title that should be truncated' },
+                { title: 'Another Tab' }
+            ]
+        };
+        expect(getDefaultSpaceTitle(space)).toBe('[This is a very long t…] +1 more');
+    });
+
+    test('should escape HTML in the title', () => {
+        const space = { tabs: [{ title: '<script>alert("xss")</script>' }] };
+        expect(getDefaultSpaceTitle(space)).toBe('[&lt;script&gt;alert(&quot;xss&quot;)&lt;/script&gt;]');
+    });
+});

tests/getTabDetailsString.test.js

@@ -0,0 +1,23 @@
+import { getTabDetailsString } from '../js/spacesRenderer.js';
+
+describe('getTabDetailsString', () => {
+    test('should return an empty string if the space is open', () => {
+        const space = { windowId: 123, tabs: [{ title: 'Test Tab' }] };
+        expect(getTabDetailsString(space)).toBe('');
+    });
+
+    test('should return (0 tabs) if the space is not open and has no tabs', () => {
+        const space = { windowId: false, tabs: [] };
+        expect(getTabDetailsString(space)).toBe('(0 tabs)');
+    });
+
+    test('should return (1 tab) if the space is not open and has one tab', () => {
+        const space = { windowId: false, tabs: [{ title: 'Test Tab' }] };
+        expect(getTabDetailsString(space)).toBe('(1 tab)');
+    });
+
+    test('should return (n tabs) if the space is not open and has multiple tabs', () => {
+        const space = { windowId: false, tabs: [{ title: 'Test Tab' }, { title: 'Another Tab' }] };
+        expect(getTabDetailsString(space)).toBe('(2 tabs)');
+    });
+});