Ability to close windows from Spaces (#23)

* Ability to close windows from Spaces

* extract a function that handles backed-up spaces and remove unnecessary test case

* Fix issue #21 and add some unit tests

* Fix issue #22: Filter out PWAs.

* solve-comments

---------

Co-authored-by: Jeff Schiller <[email protected]>

Author: Mariam-Saeed

js/background/background.js

@@ -328,6 +328,21 @@ async function processMessage(request, sender) {
             }
             return undefined;
 
+        case 'closeWindow':
+            windowId = cleanParameter(request.windowId);
+            if(windowId) {
+                try {
+                    const window = await chrome.windows.get(windowId);
+                    if (window) {
+                        await chrome.windows.remove(windowId);
+                        return true;
+                    }
+                } catch (error) {
+                    console.error("Error closing window:", error);
+                }
+                return false;
+            }
+
         case 'updateSessionName':
             sessionId = cleanParameter(request.sessionId);
             if (sessionId && request.sessionName) {

js/spaces.js

@@ -131,6 +131,7 @@ function updateButtons(space) {
         sessionId || windowId ? 'inline-block' : 'none';
     nodes.actionDelete.style.display =
         !windowId && sessionId ? 'inline-block' : 'none';
+    nodes.actionClose.style.display = windowId ? 'inline-block' : 'none';
 }
 
 function renderTabs(space) {
@@ -368,6 +369,29 @@ async function handleDelete() {
     }
 }
 
+async function handleClose() {
+  if (!globalSelectedSpace || !globalSelectedSpace.windowId) {
+    console.error("No opened window is currently selected.");
+    return;
+  }
+  const { windowId, sessionId } = globalSelectedSpace;
+
+  // Only show confirm if the space is unnamed
+  if (!sessionId) {
+    const confirm = window.confirm(
+      "Are you sure you want to close this window?"
+    );
+    if (!confirm) return;
+  }
+
+  chrome.runtime.sendMessage({ action: 'closeWindow', windowId });
+  await updateSpacesList();
+
+  // Clear the detail view since the closed window was selected
+  globalSelectedSpace = null;
+  renderSpaceDetail(false, false);
+}
+
 // import accepts either a newline separated list of urls or a json backup object
 async function handleImport() {
     let urlList;
@@ -590,6 +614,9 @@ function addEventListeners() {
     nodes.actionDelete.addEventListener('click', () => {
         handleDelete();
     });
+    nodes.actionClose.addEventListener('click', () => {
+        handleClose();
+    });
     nodes.actionImport.addEventListener('click', e => {
         e.preventDefault();
         toggleModal(true);
@@ -688,6 +715,7 @@ if (typeof window !== 'undefined') {
         nodes.actionSwitch = document.getElementById('actionSwitch');
         nodes.actionOpen = document.getElementById('actionOpen');
         nodes.actionEdit = document.getElementById('actionEdit');
+        nodes.actionClose = document.getElementById('actionClose');
         nodes.actionExport = document.getElementById('actionExport');
         nodes.actionBackup = document.getElementById('actionBackup');
         nodes.actionDelete = document.getElementById('actionDelete');

spaces.html

@@ -50,6 +50,7 @@ <h2>Import / Export:</h2>
                     <button id='actionEdit' title="Rename space" class="button fa fa-pencil"></button>
                     <button id='actionExport' title="Export space" class="button fa fa-download"></button>
                     <button id='actionDelete' title="Delete space" class="button fa fa-trash"></button>
+                    <button id='actionClose' title="Close space" class="button fa fa-times-circle"></button>
                 </div>
             </div>