Fix issue #21 and add some unit tests

Author: codedread

CHANGELOG.md

@@ -8,7 +8,7 @@ All notable changes to this project will be documented in this file.
 
 - Fixed [issue #16](https://github.com/codedread/spaces/issues/16): Stop duplicating tabs of a closed Space when tab is clicked from the Spaces window.
 - Fixed [issue #14](https://github.com/codedread/spaces/issues/14): Open Spaces windows on the currently-active display.
-- Increased unit test coverage from 8.11% to 10.12%.
+- Increased unit test coverage from 8.11% to 10.32%.
 
 
 ## [1.1.5] - 2025-09-08

js/spaces.js

@@ -1,5 +1,9 @@
 /* global chrome */
 
+/**
+ * @typedef {import('./common.js').Space} Space
+ */
+
 import { getHashVariable } from './common.js';
 import { checkSessionOverwrite, escapeHtml } from './utils.js';
 
@@ -662,22 +666,6 @@ async function updateSpaceDetail(useCachedSpace) {
     }
 }
 
-function addDuplicateMetadata(space) {
-    const dupeCounts = {};
-
-    space.tabs.forEach(tab => {
-        // eslint-disable-next-line no-param-reassign
-        tab.title = tab.title || tab.url;
-        dupeCounts[tab.title] = dupeCounts[tab.title]
-            ? dupeCounts[tab.title] + 1
-            : 1;
-    });
-    space.tabs.forEach(tab => {
-        // eslint-disable-next-line no-param-reassign
-        tab.duplicate = dupeCounts[tab.title] > 1;
-    });
-}
-
 /**
  * Initialize the spaces window.
  * This function should be called from the HTML page after the DOM is loaded.
@@ -725,6 +713,32 @@ if (typeof window !== 'undefined') {
 
 // Module-level helper functions.
 
+/**
+ * Adds duplicate metadata to tabs within a space.
+ * Normalizes tab titles (using URL if title is missing) and marks tabs as duplicates
+ * if multiple tabs have the same title.
+ * 
+ * @param {Space} space - The space object containing an array of tabs
+ */
+function addDuplicateMetadata(space) {
+    if (!space || !Array.isArray(space.tabs)) {
+        return;
+    }
+    const dupeCounts = {};
+
+    space.tabs.forEach(tab => {
+        // eslint-disable-next-line no-param-reassign
+        tab.title = tab.title || tab.url;
+        dupeCounts[tab.title] = dupeCounts[tab.title]
+            ? dupeCounts[tab.title] + 1
+            : 1;
+    });
+    space.tabs.forEach(tab => {
+        // eslint-disable-next-line no-param-reassign
+        tab.duplicate = dupeCounts[tab.title] > 1;
+    });
+}
+
 /**
  * Extracts the original URL from a Great Suspender extension suspended tab URL.
  * Great Suspender URLs have the format: chrome-extension://id/suspended.html?uri=originalUrl
@@ -774,4 +788,4 @@ async function getSpacesForBackup() {
 }
 
 // Export for testing
-export { getSpacesForBackup, normaliseTabUrl };
+export { addDuplicateMetadata, getSpacesForBackup, normaliseTabUrl };

tests/addDuplicateMetadata.test.js

@@ -0,0 +1,94 @@
+import { addDuplicateMetadata } from '../js/spaces.js';
+
+describe('addDuplicateMetadata', () => {
+  it('should mark duplicate tabs based on title', () => {
+    const space = {
+      tabs: [
+        { title: 'Gmail', url: 'https://gmail.com' },
+        { title: 'GitHub', url: 'https://github.com' },
+        { title: 'Gmail', url: 'https://mail.google.com' },
+        { title: 'Unique Tab', url: 'https://unique.com' },
+      ],
+    };
+
+    addDuplicateMetadata(space);
+
+    expect(space.tabs[0].duplicate).toBe(true); // Gmail (duplicate)
+    expect(space.tabs[1].duplicate).toBe(false); // GitHub (unique)
+    expect(space.tabs[2].duplicate).toBe(true); // Gmail (duplicate)
+    expect(space.tabs[3].duplicate).toBe(false); // Unique Tab (unique)
+  });
+
+  it('should use URL as title when title is missing', () => {
+    const space = {
+      tabs: [
+        { url: 'https://example.com' }, // no title
+        { title: '', url: 'https://empty-title.com' }, // empty title
+        { title: null, url: 'https://null-title.com' }, // null title
+        { title: 'https://example.com', url: 'https://different.com' }, // same as first URL
+      ],
+    };
+
+    addDuplicateMetadata(space);
+
+    expect(space.tabs[0].title).toBe('https://example.com');
+    expect(space.tabs[1].title).toBe('https://empty-title.com');
+    expect(space.tabs[2].title).toBe('https://null-title.com');
+    expect(space.tabs[3].title).toBe('https://example.com');
+
+    // Check duplicates
+    expect(space.tabs[0].duplicate).toBe(true); // https://example.com (duplicate)
+    expect(space.tabs[1].duplicate).toBe(false); // https://empty-title.com (unique)
+    expect(space.tabs[2].duplicate).toBe(false); // https://null-title.com (unique)
+    expect(space.tabs[3].duplicate).toBe(true); // https://example.com (duplicate)
+  });
+
+  it('should handle empty tabs array', () => {
+    const space = { tabs: [] };
+    
+    addDuplicateMetadata(space);
+    
+    expect(space.tabs).toEqual([]);
+  });
+
+  it('should handle null or undefined space safely', () => {
+    expect(() => addDuplicateMetadata(null)).not.toThrow();
+    expect(() => addDuplicateMetadata(undefined)).not.toThrow();
+    expect(() => addDuplicateMetadata({})).not.toThrow();
+    expect(() => addDuplicateMetadata({ tabs: null })).not.toThrow();
+  });
+
+  it('should handle space without tabs array', () => {
+    const space = { name: 'Test Space' }; // no tabs property
+    
+    expect(() => addDuplicateMetadata(space)).not.toThrow();
+  });
+
+  it('should mark all tabs as duplicates when all have same title', () => {
+    const space = {
+      tabs: [
+        { title: 'Same Title', url: 'https://url1.com' },
+        { title: 'Same Title', url: 'https://url2.com' },
+        { title: 'Same Title', url: 'https://url3.com' },
+      ],
+    };
+
+    addDuplicateMetadata(space);
+
+    expect(space.tabs[0].duplicate).toBe(true);
+    expect(space.tabs[1].duplicate).toBe(true);
+    expect(space.tabs[2].duplicate).toBe(true);
+  });
+
+  it('should handle single tab as non-duplicate', () => {
+    const space = {
+      tabs: [
+        { title: 'Only Tab', url: 'https://only.com' },
+      ],
+    };
+
+    addDuplicateMetadata(space);
+
+    expect(space.tabs[0].duplicate).toBe(false);
+  });
+});