Skip to content

Commit c3cfd50

Browse files
author
stevecwilkinson
committed
misc: removed redundant duplicate reference, corrected minor code style issues
1 parent d275c3a commit c3cfd50

File tree

7 files changed

+54
-26
lines changed

7 files changed

+54
-26
lines changed

‎StandardWebhooks.sln‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "doc", "doc", "{B68EAE5C-832
1919
doc\releases.md = doc\releases.md
2020
EndProjectSection
2121
EndProject
22+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "misc", "misc", "{02EA681E-C7D8-13C7-8484-4AC65E1B71E8}"
23+
ProjectSection(SolutionItems) = preProject
24+
src\Directory.Build.props = src\Directory.Build.props
25+
EndProjectSection
26+
EndProject
2227
Global
2328
GlobalSection(SolutionConfigurationPlatforms) = preSolution
2429
Debug|Any CPU = Debug|Any CPU

‎doc/releases.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
# Releases
22

3+
# 1.1.2
4+
5+
Full changelog: [1.1.1 -> 1.1.2](https://github.com/codefactors/StandardWebhooks/compare/1.1.1...1.1.2)
6+
7+
## What's Changed
8+
9+
### Update
10+
- Misc: removed redundant duplicate reference
11+
312
# 1.1.1
413

514
Full changelog: [1.0.36 -> 1.1.1](https://github.com/codefactors/StandardWebhooks/compare/1.0.36...1.1.1)

‎src/Directory.Build.props‎

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,27 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project>
3-
4-
<PropertyGroup>
5-
<Authors>Codefactors Ltd</Authors>
6-
<Copyright>Copyright (c) 2024, Codefactors Ltd</Copyright>
7-
<Company>Codefactors Ltd</Company>
8-
<Description>An implementation of Standard Webhooks for use in .NET Core and ASP.NET Core projects</Description>
9-
<PackageProjectUrl>https://github.com/codefactors/StandardWebhooks</PackageProjectUrl>
10-
<PackageReadmeFile>README.md</PackageReadmeFile>
11-
<PackageLicenseFile>LICENSE.md</PackageLicenseFile>
12-
<RepositoryUrl>https://github.com/codefactors/StandardWebhooks</RepositoryUrl>
13-
</PropertyGroup>
14-
15-
<ItemGroup>
16-
<PackageReference Include="MinVer" Version="5.0.0" PrivateAssets="All"/>
17-
</ItemGroup>
183

19-
<ItemGroup>
20-
<None Include="$(SolutionDir)LICENSE.md" Pack="true" PackagePath="" />
21-
<None Include="$(SolutionDir)src\StandardWebhooks\README.md" Pack="true" PackagePath="" />
22-
</ItemGroup>
4+
<PropertyGroup>
5+
<Authors>Codefactors Ltd</Authors>
6+
<Copyright>Copyright (c) 2024, Codefactors Ltd</Copyright>
7+
<Company>Codefactors Ltd</Company>
8+
<Description>An implementation of Standard Webhooks for use in .NET Core and ASP.NET Core projects</Description>
9+
<PackageProjectUrl>https://github.com/codefactors/StandardWebhooks</PackageProjectUrl>
10+
<PackageReadmeFile>README.md</PackageReadmeFile>
11+
<PackageLicenseFile>LICENSE.md</PackageLicenseFile>
12+
<RepositoryUrl>https://github.com/codefactors/StandardWebhooks</RepositoryUrl>
13+
</PropertyGroup>
14+
15+
<ItemGroup>
16+
<PackageReference Include="MinVer" Version="6.0.0">
17+
<PrivateAssets>all</PrivateAssets>
18+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
19+
</PackageReference>
20+
</ItemGroup>
21+
22+
<ItemGroup>
23+
<None Include="$(SolutionDir)LICENSE.md" Pack="true" PackagePath="" />
24+
<None Include="$(SolutionDir)src\StandardWebhooks\README.md" Pack="true" PackagePath="" />
25+
</ItemGroup>
2326

2427
</Project>

‎src/StandardWebhooks/StandardWebhook.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ public string Sign(
169169
return signature.Slice(0, charsWritten + 3).ToString();
170170
}
171171

172-
173172
/// <summary>
174173
/// Generates an <see cref="HttpContent"/> that contains the supplied payload, with the appropriate
175174
/// Standard Webhooks headers added, including the signature for the payload.

‎src/StandardWebhooks/StandardWebhooks.csproj‎

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,22 @@
1313
<IsPackable>true</IsPackable>
1414
</PropertyGroup>
1515

16+
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net8.0|AnyCPU'">
17+
<NoWarn>1701;1702;MSB4057</NoWarn>
18+
</PropertyGroup>
19+
20+
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net9.0|AnyCPU'">
21+
<NoWarn>1701;1702;MSB4057</NoWarn>
22+
</PropertyGroup>
23+
24+
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net8.0|AnyCPU'">
25+
<NoWarn>1701;1702;MSB4057</NoWarn>
26+
</PropertyGroup>
27+
28+
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net9.0|AnyCPU'">
29+
<NoWarn>1701;1702;MSB4057</NoWarn>
30+
</PropertyGroup>
31+
1632
<ItemGroup>
1733
<Compile Include="..\GlobalSuppressions.cs" Link="GlobalSuppressions.cs" />
1834
</ItemGroup>
@@ -26,10 +42,6 @@
2642
<PrivateAssets>all</PrivateAssets>
2743
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2844
</PackageReference>
29-
<PackageReference Include="MinVer" Version="6.0.0">
30-
<PrivateAssets>all</PrivateAssets>
31-
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
32-
</PackageReference>
3345
</ItemGroup>
3446

3547
<ItemGroup>

‎src/StandardWebhooks/WebhookContent.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ private WebhookContent(byte[] content)
3535
/// <returns>New instance of a <see cref="WebhookContent{T}"/>.</returns>
3636
public static WebhookContent<T> Create(T content, JsonSerializerOptions? jsonOptions = null)
3737
{
38-
#pragma warning disable IL3050 This overload can still be used in NativeAOT as long as the serializer context has been provided to the options object.
38+
#pragma warning disable IL3050 // This overload can still be used in NativeAOT as long as the serializer context has been provided to the options object.
3939
#pragma warning disable IL2026
4040
var utf8bytes = JsonSerializer.SerializeToUtf8Bytes(content, jsonOptions ?? WebhookContentDefaults.JsonSerializerOptions);
4141
#pragma warning restore IL2026

‎src/StandardWebhooks/WebhookContentDefaults.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
namespace StandardWebhooks
1111
{
1212
/// <summary>
13-
/// Internal defaults for <see cref="WebhookContent{T}"/>
13+
/// Internal defaults for <see cref="WebhookContent{T}"/>.
1414
/// </summary>
1515
internal static class WebhookContentDefaults
1616
{

0 commit comments

Comments
 (0)