Fix some mypy warnings in archinstall/lib/ (archlinux#3103)

Author: correctmost

archinstall/lib/args.py

@@ -326,7 +326,7 @@ def _read_file(self, path: Path) -> str:
 
 		return path.read_text()
 
-	def _cleanup_config(self, config: Namespace | dict) -> dict[str, Any]:
+	def _cleanup_config(self, config: Namespace | dict[str, Any]) -> dict[str, Any]:
 		clean_args = {}
 		for key, val in config.items():
 			if isinstance(val, dict):

archinstall/lib/configuration.py

@@ -20,7 +20,7 @@
 
 
 class ConfigurationOutput:
-	def __init__(self, config: dict):
+	def __init__(self, config: dict[str, Any]):
 		"""
 		Configuration output handler to parse the existing configuration data structure and prepare for output on the
 		console and for saving it to configuration files

archinstall/lib/disk/device_model.py

@@ -439,11 +439,17 @@ def __le__(self, other: Size) -> bool:
 		return self._normalize() <= other._normalize()
 
 	@override
-	def __eq__(self, other) -> bool:
+	def __eq__(self, other: object) -> bool:
+		if not isinstance(other, Size):
+			return NotImplemented
+
 		return self._normalize() == other._normalize()
 
 	@override
-	def __ne__(self, other) -> bool:
+	def __ne__(self, other: object) -> bool:
+		if not isinstance(other, Size):
+			return NotImplemented
+
 		return self._normalize() != other._normalize()
 
 	def __gt__(self, other: Size) -> bool:

archinstall/lib/general.py

@@ -477,7 +477,7 @@ def run_custom_user_commands(commands: list[str], installation: Installer) -> No
 		os.unlink(chroot_path)
 
 
-def json_stream_to_structure(configuration_identifier: str, stream: str, target: dict) -> bool:
+def json_stream_to_structure(configuration_identifier: str, stream: str, target: dict[str, Any]) -> bool:
 	"""
 	Load a JSON encoded dictionary from a stream and merge it into an existing dictionary.
 	A stream can be a filepath, a URL or a raw JSON string.

archinstall/lib/installer.py

@@ -72,7 +72,7 @@ def __init__(
 		if accessibility_tools_in_use():
 			self._base_packages.extend(__accessibility_packages__)
 
-		self.post_base_install: list[Callable] = []
+		self.post_base_install: list[Callable] = []  # type: ignore[type-arg]
 
 		# TODO: Figure out which one of these two we'll use.. But currently we're mixing them..
 		storage['session'] = self

archinstall/lib/models/gen.py

@@ -40,7 +40,10 @@ def pkg_version(self) -> str:
 		return self.pkgver
 
 	@override
-	def __eq__(self, other) -> bool:
+	def __eq__(self, other: object) -> bool:
+		if not isinstance(other, PackageSearchResult):
+			return NotImplemented
+
 		return self.pkg_version == other.pkg_version
 
 	def __lt__(self, other: 'PackageSearchResult') -> bool:
@@ -99,7 +102,10 @@ def pkg_version(self) -> str:
 		return self.version
 
 	@override
-	def __eq__(self, other) -> bool:
+	def __eq__(self, other: object) -> bool:
+		if not isinstance(other, LocalPackage):
+			return NotImplemented
+
 		return self.pkg_version == other.pkg_version
 
 	def __lt__(self, other: 'LocalPackage') -> bool:

archinstall/lib/models/mirrors.py

@@ -57,6 +57,7 @@ def speed(self) -> float:
 					with urllib.request.urlopen(req, None, 5) as handle, DownloadTimer(timeout=5) as timer:
 						size = len(handle.read())
 
+					assert timer.time is not None
 					self._speed = size / timer.time
 					debug(f"    speed: {self._speed} ({int(self._speed / 1024 / 1024 * 100) / 100}MiB/s)")
 				# Do not retry error

archinstall/lib/models/users.py

@@ -140,7 +140,7 @@ def _parse(cls, config_users: list[dict[str, Any]]) -> list['User']:
 		return users
 
 	@classmethod
-	def _parse_backwards_compatible(cls, config_users: dict, sudo: bool) -> list['User']:
+	def _parse_backwards_compatible(cls, config_users: dict[str, dict[str, str]], sudo: bool) -> list['User']:
 		if len(config_users.keys()) > 0:
 			username = list(config_users.keys())[0]
 			password = config_users[username]['!password']
@@ -153,8 +153,8 @@ def _parse_backwards_compatible(cls, config_users: dict, sudo: bool) -> list['Us
 	@classmethod
 	def parse_arguments(
 		cls,
-		config_users: list[dict[str, str]] | dict[str, str],
-		config_superusers: list[dict[str, str]] | dict[str, str]
+		config_users: list[dict[str, str]] | dict[str, dict[str, str]],
+		config_superusers: list[dict[str, str]] | dict[str, dict[str, str]]
 	) -> list['User']:
 		users = []
 

archinstall/lib/networking.py

@@ -6,8 +6,8 @@
 import ssl
 import struct
 import time
-from types import FrameType
-from typing import Any
+from types import FrameType, TracebackType
+from typing import Any, Self
 from urllib.error import URLError
 from urllib.parse import urlencode
 from urllib.request import urlopen
@@ -40,15 +40,15 @@ def raise_timeout(self, signl: int, frame: FrameType | None) -> None:
 		'''
 		raise DownloadTimeout(f'Download timed out after {self.timeout} second(s).')
 
-	def __enter__(self):
+	def __enter__(self) -> Self:
 		if self.timeout > 0:
 			self.previous_handler = signal.signal(signal.SIGALRM, self.raise_timeout)  # type: ignore[assignment]
 			self.previous_timer = signal.alarm(self.timeout)
 
 		self.start_time = time.time()
 		return self
 
-	def __exit__(self, typ, value, traceback) -> None:
+	def __exit__(self, typ: type[BaseException] | None, value: BaseException | None, traceback: TracebackType | None) -> None:
 		if self.start_time:
 			time_delta = time.time() - self.start_time
 			signal.alarm(0)
@@ -164,7 +164,7 @@ def build_icmp(payload: bytes) -> bytes:
 	return struct.pack('!BBHHH', 8, 0, checksum, 0, 1) + payload
 
 
-def ping(hostname, timeout=5) -> int:
+def ping(hostname, timeout: int = 5) -> int:
 	watchdog = select.epoll()
 	started = time.time()
 	random_identifier = f'archinstall-{random.randint(1000, 9999)}'.encode()

archinstall/lib/output.py

@@ -20,7 +20,7 @@ class FormattedOutput:
 	def _get_values(
 		cls,
 		o: 'DataclassInstance',
-		class_formatter: str | Callable | None = None,
+		class_formatter: str | Callable | None = None,  # type: ignore[type-arg]
 		filter_list: list[str] = []
 	) -> dict[str, Any]:
 		"""
@@ -52,7 +52,7 @@ def _get_values(
 	def as_table(
 		cls,
 		obj: list[Any],
-		class_formatter: str | Callable | None = None,
+		class_formatter: str | Callable | None = None,  # type: ignore[type-arg]
 		filter_list: list[str] = [],
 		capitalize: bool = False
 	) -> str: