@@ -144,7 +144,7 @@ def optimize_python_code( # noqa: D417
144144 logger .info ("!lsp|Generating optimized candidates…" )
145145 console .rule ()
146146 try :
147- response = self .make_ai_service_request ("/optimize" , payload = payload , timeout = 600 )
147+ response = self .make_ai_service_request ("/optimize" , payload = payload , timeout = 60 )
148148 except requests .exceptions .RequestException as e :
149149 logger .exception (f"Error generating optimized candidates: { e } " )
150150 ph ("cli-optimize-error-caught" , {"error" : str (e )})
@@ -209,7 +209,7 @@ def optimize_python_code_line_profiler( # noqa: D417
209209 console .rule ()
210210 return []
211211 try :
212- response = self .make_ai_service_request ("/optimize-line-profiler" , payload = payload , timeout = 600 )
212+ response = self .make_ai_service_request ("/optimize-line-profiler" , payload = payload , timeout = 60 )
213213 except requests .exceptions .RequestException as e :
214214 logger .exception (f"Error generating optimized candidates: { e } " )
215215 ph ("cli-optimize-error-caught" , {"error" : str (e )})
@@ -261,7 +261,7 @@ def optimize_python_code_refinement(self, request: list[AIServiceRefinerRequest]
261261 logger .debug (f"Refining { len (request )} optimizations…" )
262262 console .rule ()
263263 try :
264- response = self .make_ai_service_request ("/refinement" , payload = payload , timeout = 600 )
264+ response = self .make_ai_service_request ("/refinement" , payload = payload , timeout = 120 )
265265 except requests .exceptions .RequestException as e :
266266 logger .exception (f"Error generating optimization refinements: { e } " )
267267 ph ("cli-optimize-error-caught" , {"error" : str (e )})
@@ -509,7 +509,7 @@ def generate_regression_tests( # noqa: D417
509509 "is_async" : function_to_optimize .is_async ,
510510 }
511511 try :
512- response = self .make_ai_service_request ("/testgen" , payload = payload , timeout = 600 )
512+ response = self .make_ai_service_request ("/testgen" , payload = payload , timeout = 90 )
513513 except requests .exceptions .RequestException as e :
514514 logger .exception (f"Error generating tests: { e } " )
515515 ph ("cli-testgen-error-caught" , {"error" : str (e )})
@@ -535,7 +535,7 @@ def generate_regression_tests( # noqa: D417
535535 ph ("cli-testgen-error-response" , {"response_status_code" : response .status_code , "error" : response .text })
536536 return None
537537
538- def get_optimization_impact (
538+ def get_optimization_review (
539539 self ,
540540 original_code : dict [Path , str ],
541541 new_code : dict [Path , str ],
@@ -547,8 +547,9 @@ def get_optimization_impact(
547547 replay_tests : str ,
548548 root_dir : Path ,
549549 concolic_tests : str , # noqa: ARG002
550+ calling_fn_details : str ,
550551 ) -> str :
551- """Compute the optimization impact of current Pull Request.
552+ """Compute the optimization review of current Pull Request.
552553
553554 Args:
554555 original_code: dict -> data structure mapping file paths to function definition for original code
@@ -561,10 +562,11 @@ def get_optimization_impact(
561562 replay_tests: str -> replay test table
562563 root_dir: Path -> path of git directory
563564 concolic_tests: str -> concolic_tests (not used)
565+ calling_fn_details: str -> filenames and definitions of functions which call the function_to_optimize
564566
565567 Returns:
566568 -------
567- - 'high' or 'low' optimization impact
569+ - 'high', 'medium' or 'low' optimization review
568570
569571 """
570572 diff_str = "\n " .join (
@@ -580,7 +582,7 @@ def get_optimization_impact(
580582 ]
581583 )
582584 code_diff = f"```diff\n { diff_str } \n ```"
583- logger .info ("!lsp|Computing Optimization Impact …" )
585+ logger .info ("!lsp|Computing Optimization Review …" )
584586 payload = {
585587 "code_diff" : code_diff ,
586588 "explanation" : explanation .raw_explanation_message ,
@@ -595,22 +597,23 @@ def get_optimization_impact(
595597 "optimized_runtime" : humanize_runtime (explanation .best_runtime_ns ),
596598 "original_runtime" : humanize_runtime (explanation .original_runtime_ns ),
597599 "codeflash_version" : codeflash_version ,
600+ "calling_fn_details" : calling_fn_details ,
598601 }
599602 console .rule ()
600603 try :
601- response = self .make_ai_service_request ("/optimization_impact " , payload = payload , timeout = 600 )
604+ response = self .make_ai_service_request ("/optimization_review " , payload = payload , timeout = 120 )
602605 except requests .exceptions .RequestException as e :
603606 logger .exception (f"Error generating optimization refinements: { e } " )
604607 ph ("cli-optimize-error-caught" , {"error" : str (e )})
605608 return ""
606609
607610 if response .status_code == 200 :
608- return cast ("str" , response .json ()["impact " ])
611+ return cast ("str" , response .json ()["review " ])
609612 try :
610613 error = cast ("str" , response .json ()["error" ])
611614 except Exception :
612615 error = response .text
613- logger .error (f"Error generating impact candidates : { response .status_code } - { error } " )
616+ logger .error (f"Error generating optimization review : { response .status_code } - { error } " )
614617 ph ("cli-optimize-error-response" , {"response_status_code" : response .status_code , "error" : error })
615618 console .rule ()
616619 return ""
0 commit comments