inspected fixes

Author: KRRT7

codeflash/cli_cmds/cmd_init.py

@@ -462,7 +462,7 @@ def determine_dependency_manager(pyproject_data: dict[str, Any]) -> DependencyMa
         return DependencyManager.POETRY
 
     # Check for uv
-    if any(key.startswith("uv") for key in tool_section.keys()):
+    if any(key.startswith("uv") for key in tool_section):
         return DependencyManager.UV
 
     # Look for pip-specific markers
@@ -555,9 +555,8 @@ def customize_codeflash_yaml_content(
 
     # Add codeflash command
     codeflash_cmd = get_codeflash_github_action_command(dep_manager)
-    optimize_yml_content = optimize_yml_content.replace("{{ codeflash_command }}", codeflash_cmd)
+    return optimize_yml_content.replace("{{ codeflash_command }}", codeflash_cmd)
 
-    return optimize_yml_content
 
 
 # Create or update the pyproject.toml file with the Codeflash dependency & configuration
@@ -596,7 +595,7 @@ def configure_pyproject_toml(setup_info: SetupInfo) -> None:
         formatter_cmds.append("disabled")
     if formatter in ["black", "ruff"]:
         try:
-            result = subprocess.run([formatter], capture_output=True, check=False)
+            subprocess.run([formatter], capture_output=True, check=False)
         except FileNotFoundError:
             click.echo(f"⚠️ Formatter not found: {formatter}, please ensure it is installed")
     codeflash_section["formatter-cmds"] = formatter_cmds

codeflash/cli_cmds/console.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import logging
-from collections.abc import Generator
 from contextlib import contextmanager
 from itertools import cycle
 from typing import TYPE_CHECKING
@@ -14,6 +13,8 @@
 from codeflash.cli_cmds.logging_config import BARE_LOGGING_FORMAT
 
 if TYPE_CHECKING:
+    from collections.abc import Generator
+
     from rich.progress import TaskID
 
 DEBUG_MODE = logging.getLogger().getEffectiveLevel() == logging.DEBUG

codeflash/code_utils/code_replacer.py

@@ -3,7 +3,7 @@
 import ast
 from collections import defaultdict
 from functools import lru_cache
-from typing import TYPE_CHECKING, TypeVar
+from typing import TYPE_CHECKING, Optional, TypeVar
 
 import libcst as cst
 
@@ -90,10 +90,10 @@ def leave_ClassDef(self, node: cst.ClassDef) -> None:
 class OptimFunctionReplacer(cst.CSTTransformer):
     def __init__(
         self,
-        modified_functions: dict[tuple[str | None, str], cst.FunctionDef] = None,
-        new_functions: list[cst.FunctionDef] = None,
-        new_class_functions: dict[str, list[cst.FunctionDef]] = None,
-        modified_init_functions: dict[str, cst.FunctionDef] = None,
+        modified_functions: Optional[dict[tuple[str | None, str], cst.FunctionDef]] = None,
+        new_functions: Optional[list[cst.FunctionDef]] = None,
+        new_class_functions: Optional[dict[str, list[cst.FunctionDef]]] = None,
+        modified_init_functions: Optional[dict[str, cst.FunctionDef]] = None,
     ) -> None:
         super().__init__()
         self.modified_functions = modified_functions if modified_functions is not None else {}

codeflash/code_utils/code_utils.py

@@ -12,7 +12,8 @@
 
 def get_qualified_name(module_name: str, full_qualified_name: str) -> str:
     if not full_qualified_name:
-        raise ValueError("full_qualified_name cannot be empty")
+        msg = "full_qualified_name cannot be empty"
+        raise ValueError(msg)
     if not full_qualified_name.startswith(module_name):
         msg = f"{full_qualified_name} does not start with {module_name}"
         raise ValueError(msg)

codeflash/code_utils/concolic_utils.py

@@ -62,7 +62,7 @@ def _split_top_level_args(self, args_str: str) -> list[str]:
 
         return result
 
-    def __init__(self):
+    def __init__(self) -> None:
         # Pre-compiling regular expressions for faster execution
         self.assert_re = re.compile(r"\s*assert\s+(.*?)(?:\s*==\s*.*)?$")
         self.unittest_re = re.compile(r"(\s*)self\.assert([A-Za-z]+)\((.*)\)$")

codeflash/code_utils/time_utils.py

@@ -16,13 +16,13 @@ def humanize_runtime(time_in_ns: int) -> str:
 
         units = re.split(r",|\s", runtime_human)[1]
 
-        if units == "microseconds" or units == "microsecond":
-            runtime_human = "%.3g" % time_micro
-        elif units == "milliseconds" or units == "millisecond":
+        if units in ("microseconds", "microsecond"):
+            runtime_human = f"{time_micro:.3g}"
+        elif units in ("milliseconds", "millisecond"):
             runtime_human = "%.3g" % (time_micro / 1000)
-        elif units == "seconds" or units == "second":
+        elif units in ("seconds", "second"):
             runtime_human = "%.3g" % (time_micro / (1000**2))
-        elif units == "minutes" or units == "minute":
+        elif units in ("minutes", "minute"):
             runtime_human = "%.3g" % (time_micro / (60 * 1000**2))
         else:  # hours
             runtime_human = "%.3g" % (time_micro / (3600 * 1000**2))

codeflash/discovery/discover_unit_tests.py

@@ -59,8 +59,7 @@ def discover_tests_pytest(
         ],
         cwd=project_root,
         check=False,
-        stdout=subprocess.PIPE,
-        stderr=subprocess.PIPE,
+        capture_output=True,
         text=True,
     )
     try:

codeflash/optimization/function_optimizer.py

@@ -243,7 +243,7 @@ def optimize_function(self) -> Result[BestOptimization, str]:
 
         best_optimization = None
 
-        for u, candidates in enumerate([optimizations_set.control, optimizations_set.experiment]):
+        for _u, candidates in enumerate([optimizations_set.control, optimizations_set.experiment]):
             if candidates is None:
                 continue
 
@@ -1088,7 +1088,8 @@ def run_and_parse_tests(
                     test_framework=self.test_cfg.test_framework,
                 )
             else:
-                raise ValueError(f"Unexpected testing type: {testing_type}")
+                msg = f"Unexpected testing type: {testing_type}"
+                raise ValueError(msg)
         except subprocess.TimeoutExpired:
             logger.exception(
                 f"Error running tests in {', '.join(str(f) for f in test_files.test_files)}.\nTimeout Error"

codeflash/result/explanation.py

@@ -38,7 +38,7 @@ def to_console_string(self) -> str:
         original_runtime_human = humanize_runtime(self.original_runtime_ns)
         best_runtime_human = humanize_runtime(self.best_runtime_ns)
 
-        explanation = (
+        return (
             f"Optimized {self.function_name} in {self.file_path}\n"
             f"{self.perf_improvement_line}\n"
             f"Runtime went down from {original_runtime_human} to {best_runtime_human} \n\n"
@@ -49,7 +49,6 @@ def to_console_string(self) -> str:
             + f"{TestResults.report_to_string(self.winning_behavioral_test_results.get_test_pass_fail_report_by_type())}\n"
         )
 
-        return explanation
 
     def explanation_message(self) -> str:
         return self.raw_explanation_message

codeflash/telemetry/sentry.py

@@ -4,7 +4,7 @@
 from sentry_sdk.integrations.logging import LoggingIntegration
 
 
-def init_sentry(enabled: bool = False, exclude_errors: bool = False):
+def init_sentry(enabled: bool = False, exclude_errors: bool = False) -> None:
     if enabled:
         sentry_logging = LoggingIntegration(
             level=logging.INFO,  # Capture info and above as breadcrumbs