Skip to content

Commit 5443f51

Browse files
committed
doing in a single loop now
1 parent 309695a commit 5443f51

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

codeflash/models/models.py

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -537,22 +537,19 @@ def report_to_tree(report: dict[TestType, dict[str, int]], title: str) -> Tree:
537537
return tree
538538

539539
def usable_runtime_data_by_test_case(self) -> dict[InvocationId, list[int]]:
540+
usable_id_to_runtime = defaultdict(list)
540541
for result in self.test_results:
541-
if result.did_pass and not result.runtime:
542-
msg = (
543-
f"Ignoring test case that passed but had no runtime -> {result.id}, "
544-
f"Loop # {result.loop_index}, Test Type: {result.test_type}, "
545-
f"Verification Type: {result.verification_type}"
546-
)
547-
logger.debug(msg)
548-
549-
usable_runtimes = [
550-
(result.id, result.runtime) for result in self.test_results if result.did_pass and result.runtime
551-
]
552-
return {
553-
usable_id: [runtime[1] for runtime in usable_runtimes if runtime[0] == usable_id]
554-
for usable_id in {runtime[0] for runtime in usable_runtimes}
555-
}
542+
if result.did_pass:
543+
if not result.runtime:
544+
msg = (
545+
f"Ignoring test case that passed but had no runtime -> {result.id}, "
546+
f"Loop # {result.loop_index}, Test Type: {result.test_type}, "
547+
f"Verification Type: {result.verification_type}"
548+
)
549+
logger.debug(msg)
550+
else:
551+
usable_id_to_runtime[result.id].append(result.runtime)
552+
return usable_id_to_runtime
556553

557554
def total_passed_runtime(self) -> int:
558555
"""Calculate the sum of runtimes of all test cases that passed.

0 commit comments

Comments
 (0)