Skip to content

Commit 683c9f6

Browse files
committed
shift check for pickle placerholder access error in comparator
1 parent e5ca10f commit 683c9f6

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

codeflash/verification/comparator.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,7 @@ def comparator(orig: Any, new: Any, superset_obj=False) -> bool:
6565
if len(orig) != len(new):
6666
return False
6767
return all(comparator(elem1, elem2, superset_obj) for elem1, elem2 in zip(orig, new))
68-
if isinstance(orig, PicklePlaceholderAccessError) or isinstance(new, PicklePlaceholderAccessError):
69-
# If this error was raised, there was an attempt to access the PicklePlaceholder, which represents an unpickleable object.
70-
# The test results should be rejected as the behavior of the unpickleable object is unknown.
71-
logger.debug("Unable to verify behavior of unpickleable object in replay test")
72-
return False
68+
7369
if isinstance(
7470
orig,
7571
(
@@ -95,6 +91,11 @@ def comparator(orig: Any, new: Any, superset_obj=False) -> bool:
9591
return True
9692
return math.isclose(orig, new)
9793
if isinstance(orig, BaseException):
94+
if isinstance(orig, PicklePlaceholderAccessError) or isinstance(new, PicklePlaceholderAccessError):
95+
# If this error was raised, there was an attempt to access the PicklePlaceholder, which represents an unpickleable object.
96+
# The test results should be rejected as the behavior of the unpickleable object is unknown.
97+
logger.debug("Unable to verify behavior of unpickleable object in replay test")
98+
return False
9899
# if str(orig) != str(new):
99100
# return False
100101
# compare the attributes of the two exception objects to determine if they are equivalent.

0 commit comments

Comments
 (0)