Skip to content

Commit bf066a9

Browse files
committed
minor bugfix
1 parent 9238fe5 commit bf066a9

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

codeflash/optimization/function_optimizer.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,10 @@ def _process_refinement_results(self) -> OptimizedCandidate | None:
171171
self.candidate_queue.put(candidate)
172172

173173
self.candidate_len += len(refinement_response)
174-
logger.info(
175-
f"Added {len(refinement_response)} candidates from refinement, total candidates now: {self.candidate_len}"
176-
)
174+
if len(refinement_response) > 0:
175+
logger.info(
176+
f"Added {len(refinement_response)} candidates from refinement, total candidates now: {self.candidate_len}"
177+
)
177178
self.refinement_done = True
178179

179180
return self.get_next_candidate()
@@ -697,15 +698,17 @@ def determine_best_candidate(
697698
)
698699
optimization_ids.append(new_best_opt.candidate.optimization_id)
699700
runtimes_list.append(new_best_opt.runtime)
700-
ranking = self.executor.submit(
701+
future_ranking = self.executor.submit(
701702
ai_service_client.generate_ranking,
702703
diffs=diff_strs,
703704
optimization_ids=optimization_ids,
704705
speedups=speedups_list,
705706
trace_id=self.function_trace_id[:-4] + exp_type if self.experiment_id else self.function_trace_id,
706707
)
707-
ranking = [x - 1 for x in ranking]
708+
concurrent.futures.wait([future_ranking])
709+
ranking = future_ranking.result()
708710
if ranking:
711+
ranking = [x - 1 for x in ranking]
709712
min_key = ranking[0]
710713
else:
711714
diff_lens_ranking = create_rank_dictionary_compact(diff_lens_list)

0 commit comments

Comments
 (0)