alidate API key early before initializing optimizer

Author: mohamedashrraf222

codeflash/api/cfapi.py

@@ -120,6 +120,70 @@ def get_user_id(api_key: Optional[str] = None) -> Optional[str]:
     return None
 
 
+def validate_api_key(api_key: Optional[str] = None) -> None:
+    """Validate that the API key is valid by attempting to retrieve the user ID.
+    
+    Raises OSError if the API key is invalid or missing.
+    
+    :param api_key: The API key to validate. If None, uses get_codeflash_api_key().
+    :raises OSError: If the API key is invalid or missing.
+    """
+    # First check if API key exists
+    if not api_key:
+        api_key = get_codeflash_api_key()
+    
+    # Make the request to validate the API key
+    try:
+        response = make_cfapi_request(
+            endpoint="/cli-get-user", 
+            method="GET", 
+            extra_headers={"cli_version": __version__}, 
+            api_key=api_key,
+            suppress_errors=True  # Don't log errors yet, we'll handle it below
+        )
+        
+        if response.status_code == 403:
+            msg = (
+                "Invalid Codeflash API key. The API key you provided is not valid.\n"
+                "Please generate a new one at https://app.codeflash.ai/app/apikeys ,\n"
+                "then set it as a CODEFLASH_API_KEY environment variable.\n"
+                "For more information, refer to the documentation at "
+                "https://docs.codeflash.ai/getting-started/codeflash-github-actions#add-your-api-key-to-your-repository-secrets."
+            )
+            raise OSError(msg)
+        elif response.status_code != 200:
+            msg = (
+                f"Failed to validate API key with Codeflash API (status {response.status_code}).\n"
+                "Please verify your API key is correct.\n"
+                "You can generate a new one at https://app.codeflash.ai/app/apikeys"
+            )
+            raise OSError(msg)
+            
+        # Check for version updates
+        if response.status_code == 200:
+            try:
+                resp_json = response.json()
+                min_version = resp_json.get("min_version")
+                if min_version and version.parse(min_version) > version.parse(__version__):
+                    msg = "Your Codeflash CLI version is outdated. Please update to the latest version using `pip install --upgrade codeflash`."
+                    raise OSError(msg)
+            except (json.JSONDecodeError, KeyError, TypeError):
+                # If response is not JSON or doesn't have min_version, that's okay
+                pass
+                
+    except OSError:
+        # Re-raise OSError as-is
+        raise
+    except Exception as e:
+        # Wrap other exceptions
+        msg = (
+            f"Failed to validate API key: {e}\n"
+            "Please verify your API key is correct.\n"
+            "You can generate a new one at https://app.codeflash.ai/app/apikeys"
+        )
+        raise OSError(msg) from e
+
+
 def suggest_changes(
     owner: str,
     repo: str,

codeflash/optimization/optimizer.py

@@ -10,7 +10,7 @@
 from typing import TYPE_CHECKING
 
 from codeflash.api.aiservice import AiServiceClient, LocalAiServiceClient
-from codeflash.api.cfapi import send_completion_email
+from codeflash.api.cfapi import send_completion_email, validate_api_key
 from codeflash.cli_cmds.console import console, logger, progress_bar
 from codeflash.code_utils import env_utils
 from codeflash.code_utils.code_utils import cleanup_paths, get_run_tmp_file
@@ -493,11 +493,24 @@ def mirror_path(path: Path, src_root: Path, dest_root: Path) -> Path:
 def run_with_args(args: Namespace) -> None:
     optimizer = None
     try:
+        # Validate API key early before initializing optimizer
+        validate_api_key()
+        
         optimizer = Optimizer(args)
         optimizer.run()
     except KeyboardInterrupt:
         logger.warning("Keyboard interrupt received. Cleaning up and exiting, please wait…")
         if optimizer:
             optimizer.cleanup_temporary_paths()
-
-        raise SystemExit from None
+        raise SystemExit(0) from None
+    except (OSError, Exception) as e:
+        # Log the error if we have an optimizer instance with cleanup
+        if optimizer:
+            logger.error(f"Error during optimization: {e}")
+            try:
+                optimizer.cleanup_temporary_paths()
+            except Exception:
+                pass
+        else:
+            logger.error(f"Error initializing optimizer: {e}")
+        raise