Skip to content

Conversation

@aseembits93
Copy link
Contributor

@aseembits93 aseembits93 commented Apr 23, 2025

User description

most repos won't have benchmarks so it makes sense to have the no benchmark option on top


PR Type

Enhancement


Description

  • Prepend no_benchmarks_option to benchmarks list

Changes walkthrough 📝

Relevant files
Enhancement
cmd_init.py
Reorder no-benchmarks option to top                                           

codeflash/cli_cmds/cmd_init.py

  • Append no_benchmarks_option at start of benchmarks_options
  • Remove the duplicate append of no_benchmarks_option at end
  • +2/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    List ordering clarity

    Inserting no_benchmarks_option via append before other operations works, but using
    benchmarks_options.insert(0, no_benchmarks_option) would make the intent of placing
    it at the top clearer and reduce coupling to subsequent list mutations.

    benchmarks_options.append(no_benchmarks_option)

    @github-actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @aseembits93 aseembits93 self-assigned this Apr 23, 2025
    @aseembits93
    Copy link
    Contributor Author

    added pycache in the ignore list

    @aseembits93 aseembits93 disabled auto-merge April 23, 2025 17:55
    misrasaurabh1
    misrasaurabh1 previously approved these changes Apr 23, 2025
    @aseembits93 aseembits93 merged commit f2f6efe into main Apr 23, 2025
    15 checks passed
    @aseembits93 aseembits93 deleted the no-benchmark-on-top branch April 23, 2025 19:33
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants