From b1d0218d7e0ecbf18cc44d4e1f72817d90520b7f Mon Sep 17 00:00:00 2001 From: aseembits93 Date: Thu, 29 May 2025 19:08:44 -0700 Subject: [PATCH 1/7] replay test template bug --- codeflash/benchmarking/replay_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codeflash/benchmarking/replay_test.py b/codeflash/benchmarking/replay_test.py index a9b3f2e29..c24385605 100644 --- a/codeflash/benchmarking/replay_test.py +++ b/codeflash/benchmarking/replay_test.py @@ -127,7 +127,7 @@ def create_trace_replay_test_code( kwargs = pickle.loads(kwargs_pkl){filter_variables} if not args: raise ValueError("No arguments provided for the method.") - ret = {class_name_alias}{method_name}(*args[1:], **kwargs) + ret = {class_name_alias}{method_name}(*args, **kwargs) """ ) test_static_method_body = textwrap.dedent( From f8cbcbd071d349a4c1f9da995a3581348bbf31de Mon Sep 17 00:00:00 2001 From: aseembits93 Date: Thu, 29 May 2025 19:41:03 -0700 Subject: [PATCH 2/7] replay test template bug --- codeflash/benchmarking/replay_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codeflash/benchmarking/replay_test.py b/codeflash/benchmarking/replay_test.py index c24385605..e5d9a81ca 100644 --- a/codeflash/benchmarking/replay_test.py +++ b/codeflash/benchmarking/replay_test.py @@ -116,7 +116,7 @@ def create_trace_replay_test_code( ret = {class_name_alias}(*args[1:], **kwargs) else: instance = args[0] # self - ret = instance{method_name}(*args[1:], **kwargs) + ret = {class_name_alias}{method_name}(*args, **kwargs) """ ) @@ -127,7 +127,7 @@ def create_trace_replay_test_code( kwargs = pickle.loads(kwargs_pkl){filter_variables} if not args: raise ValueError("No arguments provided for the method.") - ret = {class_name_alias}{method_name}(*args, **kwargs) + ret = {class_name_alias}{method_name}(*args[1:], **kwargs) """ ) test_static_method_body = textwrap.dedent( From c566436aacdd1d423ad45262fdb0ceedcfd39f20 Mon Sep 17 00:00:00 2001 From: aseembits93 Date: Fri, 30 May 2025 15:03:50 -0700 Subject: [PATCH 3/7] modify existing test --- codeflash/version.py | 4 ++-- tests/test_trace_benchmarks.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/codeflash/version.py b/codeflash/version.py index 2f71ae6c0..d9fc9f86b 100644 --- a/codeflash/version.py +++ b/codeflash/version.py @@ -1,3 +1,3 @@ # These version placeholders will be replaced by poetry-dynamic-versioning during `poetry build`. -__version__ = "0.12.4" -__version_tuple__ = (0, 12, 4) +__version__ = "0.12.4.post15.dev0+246801dd" +__version_tuple__ = (0, 12, 4, "post15", "dev0", "246801dd") diff --git a/tests/test_trace_benchmarks.py b/tests/test_trace_benchmarks.py index 72c0267a8..72ebf7e03 100644 --- a/tests/test_trace_benchmarks.py +++ b/tests/test_trace_benchmarks.py @@ -112,7 +112,7 @@ def test_code_to_optimize_bubble_sort_codeflash_trace_Sorter_sorter(): ret = code_to_optimize_bubble_sort_codeflash_trace_Sorter(*args[1:], **kwargs) else: instance = args[0] # self - ret = instance.sorter(*args[1:], **kwargs) + ret = code_to_optimize_bubble_sort_codeflash_trace_Sorter.sorter(*args, **kwargs) def test_code_to_optimize_bubble_sort_codeflash_trace_Sorter_sort_class(): for args_pkl, kwargs_pkl in get_next_arg_and_return(trace_file=trace_file_path, benchmark_function_name="test_class_sort2", function_name="sort_class", file_path=r"{bubble_sort_path}", class_name="Sorter", num_to_get=100): @@ -139,7 +139,7 @@ def test_code_to_optimize_bubble_sort_codeflash_trace_Sorter___init__(): ret = code_to_optimize_bubble_sort_codeflash_trace_Sorter(*args[1:], **kwargs) else: instance = args[0] # self - ret = instance(*args[1:], **kwargs) + ret = code_to_optimize_bubble_sort_codeflash_trace_Sorter(*args, **kwargs) """ assert test_class_sort_path.read_text("utf-8").strip()==test_class_sort_code.strip() From ab59532f7bc3d933fca57fb1b483e410cf896958 Mon Sep 17 00:00:00 2001 From: aseembits93 Date: Fri, 30 May 2025 15:04:53 -0700 Subject: [PATCH 4/7] restore version --- codeflash/version.py | 4 ++-- tests/test_comparator.py | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/codeflash/version.py b/codeflash/version.py index d9fc9f86b..16cb84c61 100644 --- a/codeflash/version.py +++ b/codeflash/version.py @@ -1,3 +1,3 @@ # These version placeholders will be replaced by poetry-dynamic-versioning during `poetry build`. -__version__ = "0.12.4.post15.dev0+246801dd" -__version_tuple__ = (0, 12, 4, "post15", "dev0", "246801dd") +__version__ = "0.12.3" +__version_tuple__ = (0, 12, 3) diff --git a/tests/test_comparator.py b/tests/test_comparator.py index 6c659e385..a487fa169 100644 --- a/tests/test_comparator.py +++ b/tests/test_comparator.py @@ -702,6 +702,8 @@ def test_torch(): assert comparator(gg, hh) assert not comparator(gg, ii) + # TODO compare torch layers + def test_returns(): a = Success(5) From 4e8f2e7f55efe420e1b54c9ccad02cf19ee91496 Mon Sep 17 00:00:00 2001 From: aseembits93 Date: Fri, 30 May 2025 15:06:41 -0700 Subject: [PATCH 5/7] cleaning up --- codeflash/benchmarking/replay_test.py | 1 - tests/test_trace_benchmarks.py | 2 -- 2 files changed, 3 deletions(-) diff --git a/codeflash/benchmarking/replay_test.py b/codeflash/benchmarking/replay_test.py index e5d9a81ca..c44649632 100644 --- a/codeflash/benchmarking/replay_test.py +++ b/codeflash/benchmarking/replay_test.py @@ -115,7 +115,6 @@ def create_trace_replay_test_code( if function_name == "__init__": ret = {class_name_alias}(*args[1:], **kwargs) else: - instance = args[0] # self ret = {class_name_alias}{method_name}(*args, **kwargs) """ ) diff --git a/tests/test_trace_benchmarks.py b/tests/test_trace_benchmarks.py index 72ebf7e03..2d5a3c6e0 100644 --- a/tests/test_trace_benchmarks.py +++ b/tests/test_trace_benchmarks.py @@ -111,7 +111,6 @@ def test_code_to_optimize_bubble_sort_codeflash_trace_Sorter_sorter(): if function_name == "__init__": ret = code_to_optimize_bubble_sort_codeflash_trace_Sorter(*args[1:], **kwargs) else: - instance = args[0] # self ret = code_to_optimize_bubble_sort_codeflash_trace_Sorter.sorter(*args, **kwargs) def test_code_to_optimize_bubble_sort_codeflash_trace_Sorter_sort_class(): @@ -138,7 +137,6 @@ def test_code_to_optimize_bubble_sort_codeflash_trace_Sorter___init__(): if function_name == "__init__": ret = code_to_optimize_bubble_sort_codeflash_trace_Sorter(*args[1:], **kwargs) else: - instance = args[0] # self ret = code_to_optimize_bubble_sort_codeflash_trace_Sorter(*args, **kwargs) """ From 49f2c44f1ded0790192e4ea71bb03c46038d4f7d Mon Sep 17 00:00:00 2001 From: aseembits93 Date: Fri, 30 May 2025 15:07:46 -0700 Subject: [PATCH 6/7] restore version --- codeflash/version.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codeflash/version.py b/codeflash/version.py index 16cb84c61..2f71ae6c0 100644 --- a/codeflash/version.py +++ b/codeflash/version.py @@ -1,3 +1,3 @@ # These version placeholders will be replaced by poetry-dynamic-versioning during `poetry build`. -__version__ = "0.12.3" -__version_tuple__ = (0, 12, 3) +__version__ = "0.12.4" +__version_tuple__ = (0, 12, 4) From 16644197579fc062233d2b4461fc4b6289728043 Mon Sep 17 00:00:00 2001 From: aseembits93 Date: Fri, 30 May 2025 15:08:19 -0700 Subject: [PATCH 7/7] restore comparator --- tests/test_comparator.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/test_comparator.py b/tests/test_comparator.py index a487fa169..6c659e385 100644 --- a/tests/test_comparator.py +++ b/tests/test_comparator.py @@ -702,8 +702,6 @@ def test_torch(): assert comparator(gg, hh) assert not comparator(gg, ii) - # TODO compare torch layers - def test_returns(): a = Success(5)