Skip to content

[Fix] Missing Arguments in create_staging #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

[Fix] Missing Arguments in create_staging #656

merged 2 commits into from
Aug 13, 2025

Conversation

@HeshamHM28
Copy link
Contributor

@HeshamHM28 HeshamHM28 commented Aug 13, 2025 •
edited by github-actions bot
Loading

User description

Summary

A recently added argument to data in process_review was not passed to create_staging, causing an error

Notes

TODO: Add a GitHub Action to automatically check that staging works correctly when new changes are introduced.

PR Type

Bug fix

Description

  • Add missing replay_tests and concolic_tests parameters

  • Include them in create_staging API payload

File Walkthrough
Relevant files
Bug fix
cfapi.py
Add missing replay and concolic tests                                       

codeflash/api/cfapi.py

  • Added parameters replay_tests and concolic_tests
  • Included "replayTests" in payload
  • Included "concolicTests" in payload
 +4/-0     

@github-actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Missing documentation

The function docstring does not mention the newly added replay_tests and concolic_tests parameters. Update the docstring to keep it accurate.

 
def create_staging(
    original_code: dict[Path, str],
    new_code: dict[Path, str],
    explanation: Explanation,
    existing_tests_source: str,
    generated_original_test_source: str,
    function_trace_id: str,
    coverage_message: str,
    replay_tests: str,
    concolic_tests: str,
) -> Response:
Breaking change

replay_tests and concolic_tests are required positional parameters without defaults. Consider providing default values to avoid breaking existing callers.

 
    replay_tests: str,
    concolic_tests: str,
) -> Response:
Input validation

There is no validation on replay_tests and concolic_tests before including them in the API payload. Validate or sanitize these inputs to prevent malformed requests.

 
"replayTests": replay_tests,
"concolicTests": concolic_tests,

@github-actions
Copy link

Failed to generate code suggestions for PR

aseembits93
aseembits93 previously approved these changes Aug 13, 2025
View reviewed changes
@HeshamHM28 HeshamHM28 enabled auto-merge August 13, 2025 22:34
@HeshamHM28 HeshamHM28 merged commit 1a9ee7f into main Aug 13, 2025
18 of 19 checks passed
@aseembits93 aseembits93 deleted the fix/staging-missing-args branch August 17, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aseembits93 aseembits93 aseembits93 approved these changes

@misrasaurabh1 misrasaurabh1 Awaiting requested review from misrasaurabh1

@mohammedahmed18 mohammedahmed18 Awaiting requested review from mohammedahmed18

Assignees

No one assigned

Labels

Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HeshamHM28 @aseembits93