Prevent hub/documents confirm page from crashing if there is no tax return (#6167)

Author: embarnard

app/views/hub/documents/confirm.html.erb

@@ -9,7 +9,7 @@
           <%= t("hub.documents.confirm.text_html",
                 document_type: @document.document_type,
                 client_name: @document.client.legal_name,
-                filing_year: @document.tax_return.year
+                filing_year: @document.tax_return&.year
                 )
           %>
         </p>

spec/controllers/hub/documents_controller_spec.rb

@@ -488,6 +488,21 @@
     end
   end
 
+  describe "#confirm" do
+    context "with an authenticated user" do
+      before { sign_in(user) }
+      let!(:document) { create :document, client: client, tax_return_id: nil }
+
+      context "with no tax return" do
+        it "returns 200 OK" do
+          get :confirm, params: { client_id: client.id, id: document.id }
+
+          expect(response).to be_ok
+        end
+      end
+    end
+  end
+
   describe "#rerun_screener" do
     let!(:document) { create :document, intake: client.intake }
     let(:params) do