add diy_email_address screen + spec tests etc

Author: spompea-cfa

app/controllers/diy/diy_email_address_controller.rb

@@ -0,0 +1,38 @@
+module Diy
+  class DiyEmailAddressController < BaseController
+    before_action :require_diy_intake
+
+    def self.show?(diy_intake)
+      # TODO: Use this version after GYR1-877 merged:
+      # diy_intake.email_address.blank? && diy_intake.email_notification_opt_in_yes?
+      # TEMP:
+      diy_intake.email_notification_opt_in_yes?
+    end
+
+    def edit
+      @form = DiyEmailAddressForm.new
+    end
+
+    def update
+      diy_intake = current_diy_intake
+      form_params = params.fetch(:diy_email_address_form, {}).permit(*DiyEmailAddressForm.attribute_names)
+      @form = DiyEmailAddressForm.new(diy_intake, form_params)
+      if @form.valid?
+        @form.save
+        after_update_success
+        track_question_answer
+        redirect_to(diy_continue_to_fsa_path)
+      else
+        after_update_failure
+        track_validation_error
+        render :edit
+      end
+    end
+
+    private
+
+    def tracking_data
+      {}
+    end
+  end
+end

app/controllers/diy/diy_notification_preference_controller.rb

@@ -15,7 +15,7 @@ def update
         after_update_success
         track_question_answer
         session[:diy_intake_id] = diy_intake.id
-        redirect_to(diy_continue_to_fsa_path)
+        redirect_to(diy_diy_email_address_path)
       else
         after_update_failure
         track_validation_error

app/forms/diy_email_address_form.rb

@@ -0,0 +1,25 @@
+class DiyEmailAddressForm < Form
+  include FormAttributes
+  attr_accessor :diy_intake
+  set_attributes_for :diy_intake, :email_address
+  # TODO need?
+  set_attributes_for :confirmation, :email_address_confirmation
+
+  validates :email_address, presence: true, 'valid_email_2/email': { mx: true }
+  # TODO need?
+  validates :email_address, confirmation: true
+  validates :email_address_confirmation, presence: true
+
+  def initialize(diy_intake = nil, params = {})
+    @diy_intake = diy_intake
+    super(params)
+  end
+
+  def save
+    diy_intake.update!(attributes_for(:diy_intake))
+  end
+
+  def self.existing_attributes(diy_intake)
+    HashWithIndifferentAccess.new(diy_intake.attributes)
+  end
+end

app/lib/navigation/diy_navigation.rb

@@ -6,7 +6,7 @@ class DiyNavigation
       Diy::QualificationsController,
       Diy::FileYourselfController,
       Diy::DiyNotificationPreferenceController,
-      #Diy::DiyEmailAddressController,
+      Diy::DiyEmailAddressController,
       Diy::ContinueToFsaController
     ].freeze
   end

app/views/diy/diy_email_address/edit.html.erb

@@ -0,0 +1,27 @@
+<% @main_question = t("views.questions.email_address.title") %>
+
+<section class="slab slab--white question-layout">
+  <div class="grid">
+    <div class="grid__item question-wrapper">
+      <div class="main-content-inner">
+        <%= image_tag("questions/email-address.svg", alt: "") %>
+
+          <%= form_with model: @form, url: diy_diy_email_address_path, local: true, method: "put", builder: VitaMinFormBuilder, html: { class: "form-card form-card--long" } do |f| %>
+          <h1 class="h2"><%= @main_question %></h1>
+          <p class="text--help">
+            <%=t("views.questions.email_address.info") %>
+          </p>
+
+          <div class="form-card__content">
+            <%= f.cfa_input_field(:email_address, t("views.questions.email_address.email_address"), classes: ["form-width--long"]) %>
+            <%= f.cfa_input_field(:email_address_confirmation, t("views.questions.email_address.email_address_confirmation"), classes: ["form-width--long"]) %>
+          </div>
+
+          <%= f.continue %>
+        </div>
+      </div>
+    </div>        
+  </div>
+</section>
+
+<% end %>

app/views/diy/diy_notification_preference/edit.html.erb

@@ -25,7 +25,9 @@
       <%= f.cfa_checkbox(:email_notification_opt_in, t("views.questions.notification_preference.options.email_notification_opt_in"), options: { checked_value: "yes", unchecked_value: "no" }) %>
       <div class="question-with-follow-up">
         <div class="question-with-follow-up__question">
-          <%= f.cfa_checkbox(:sms_notification_opt_in, t("views.questions.notification_preference.options.sms_notification_opt_in"), options: { checked_value: "yes", unchecked_value: "no", "data-follow-up": "#sms-opt-in" }) %>
+          <%# TODO remove once phone_number screen added.
+          <X= f.cfa_checkbox(:sms_notification_opt_in, t("views.questions.notification_preference.options.sms_notification_opt_in"), options: { checked_value: "yes", unchecked_value: "no", "data-follow-up": "#sms-opt-in" }) X>
+          %>
         </div>
 
         <p class="text--small spacing-above-25">

spec/controllers/diy/diy_email_address_controller_spec.rb

@@ -0,0 +1,131 @@
+require "rails_helper"
+
+RSpec.describe Diy::DiyEmailAddressController do
+  render_views
+
+  test_email_address = 'test@test.test'
+
+  let(:diy_intake) { create(:diy_intake, email_address: test_email_address) }
+
+  before do
+    allow(subject).to receive(:current_diy_intake).and_return(diy_intake)
+    allow(MixpanelService).to receive(:send_event)
+  end
+
+  describe ".show?" do
+    context "when they do not have an email address and opted in to email" do
+      let!(:diy_intake) { create :diy_intake, email_notification_opt_in: "yes" }
+      xit "returns true" do
+        pry
+        expect(described_class.show?(diy_intake)).to eq true
+      end
+    end
+
+    context "when they have an email" do
+      let!(:diy_intake) { create :diy_intake, email_notification_opt_in: "yes", email_address: "email@example.test" }
+      xit "returns false" do
+        expect(described_class.show?(diy_intake)).to eq false
+      end
+    end
+
+    context "when they have not opted in to email" do
+      let!(:diy_intake) { create :diy_intake, email_notification_opt_in: "no" }
+      xit "returns false" do
+        expect(described_class.show?(diy_intake)).to eq false
+      end
+    end
+  end
+
+  describe "#edit" do
+    it "renders successfully" do
+      get :edit, session: { diy_intake_id: diy_intake.id }
+      expect(response).to be_successful
+    end
+  end
+
+  describe "#update" do
+    context "with valid params" do
+      let(:params) do
+        {
+          diy_email_address_form: {
+            email_address: "iloveplant@example.test",
+            email_address_confirmation: "iloveplant@example.test",
+          }
+        }
+      end
+
+      it "sets the email address on the diy_intake" do
+        expect do
+          post :update, params: params, session: { diy_intake_id: diy_intake.id }
+        end.to change { diy_intake.reload.email_address }
+          .from(test_email_address)
+          .to("iloveplant@example.test")
+      end
+
+      it "sends an event to mixpanel without the email address data" do
+        post :update, params: params, session: { diy_intake_id: diy_intake.id }
+
+        expect(MixpanelService).to have_received(:send_event).with(hash_including(
+          event_name: "question_answered",
+          data: {}
+        ))
+      end
+    end
+
+    context "with non-matching email addresses" do
+      let(:params) do
+        {
+          diy_email_address_form: {
+            email_address: "iloveplant@example.test",
+            email_address_confirmation: "iloveplarnt@example.test",
+          }
+        }
+      end
+
+      it "shows validation errors" do
+        post :update, params: params, session: { diy_intake_id: diy_intake.id }
+
+        expect(response.body).to include("Please double check that the email addresses match.")
+      end
+
+      it "sends an event to mixpanel with relevant data" do
+        post :update, params: params, session: { diy_intake_id: diy_intake.id }
+
+        expect(MixpanelService).to have_received(:send_event).with(hash_including(
+          event_name: "validation_error",
+          data: {
+            invalid_email_address_confirmation: true
+          })
+        )
+      end
+    end
+
+    context "with an invalid email address" do
+      let(:params) do
+        {
+          diy_email_address_form: {
+            email_address: "iloveplant@example.",
+            email_address_confirmation: "iloveplant@example.",
+          }
+        }
+      end
+
+      it "shows validation errors" do
+        post :update, params: params, session: { diy_intake_id: diy_intake.id }
+
+        expect(response.body).to include("Please enter a valid email address.")
+      end
+
+      it "sends an event to mixpanel with relevant data" do
+        post :update, params: params, session: { diy_intake_id: diy_intake.id }
+
+        expect(MixpanelService).to have_received(:send_event).with(hash_including(
+          event_name: "validation_error",
+          data: {
+            invalid_email_address: true
+          }
+        ))
+      end
+    end
+  end
+end

spec/forms/diy_email_address_form_spec.rb

@@ -0,0 +1,35 @@
+require "rails_helper"
+
+describe DiyEmailAddressForm do
+  # TODO remove this initial `email_address` value as part of GYR1-877.
+  let(:diy_intake) { create :diy_intake, email_address: 'test@test.test' }
+
+  context "validations" do
+    it_behaves_like "email address validation", EmailAddressForm do
+      let(:form_object) { diy_intake }
+    end
+  end
+
+  describe "#save" do
+    it "saves the email address" do
+      expect {
+        described_class.new(diy_intake, {
+          email_address: "mango@fruitnames.test",
+          email_address_confirmation: "mango@fruitnames.test"
+        }).save
+      }.to change(diy_intake, :email_address).to("mango@fruitnames.test")
+    end
+
+    context "when the email address gets updated to a new address" do
+      let(:diy_intake) { create :diy_intake, email_address: "martin@fruitnames.test" }
+      it "saves the updated email address" do
+        expect {
+          described_class.new(diy_intake, {
+            email_address: "mango@fruitnames.test",
+            email_address_confirmation: "mango@fruitnames.test"
+          }).save
+        }.to change(diy_intake, :email_address).to("mango@fruitnames.test")
+      end
+    end
+  end
+end